-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update Volar identifier for VSCode Marketplace #22189
Conversation
Thanks for taking the time to open a PR!
|
…cypress into volar-marketplace-identifier
Test summaryRun details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening a PR @astone123
@mike-plummer @flotwig any idea why Percy is showing visual changes for this? Seems like there shouldn't be any based on my changes |
The changes in Percy are all flake, some have to do with loaders/spinners, a lot are an element in the header that actually is flaky in the launchpad and has a ticket. Percy is great but with the new app some of the snapshots haven't been given enough attention around exactly at what moment to take the snapshot, or what elements to block out. So we get quite a bit of noise in the diffs based on the position of a spinner or the precise status in the command log, which is based on performance at the time, and not deterministic. There's some WIP out there that will address a lot of this, though I bet we can make small improvements before that lands. |
Nice, going to merge - windows CI is red here, but I'm confident the errors are resolved in #22234 (review), and you did not introduce any just by changing some markdown files. |
* Update Volar identifier for VSCode Marketplace * chore: Update Volar identifier for VSCode Marketplace Co-authored-by: Zach Bloomquist <[email protected]> Co-authored-by: Lachlan Miller <[email protected]>
Additional details
When installing recommended VSCode extensions in my IDE, I noticed this warning
It looks like the identifier for the Volar extension changed from
johnsoncodehk.volar
tovue.volar
at some point. This PR updates the recommended extensions to use the new identifier so that VSCode can find the Volar extension when installing recommended extensions. The links to the VSCode marketplace on the web seemed to still work, but I updated those as well just so that we're using the correct identifier.PR Tasks
cypress-documentation
?type definitions
?