-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: windows #22234
fix: windows #22234
Conversation
Thanks for taking the time to open a PR!
|
Test summaryRun details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I will find out why #22118 has (frustrating) windows on CI fails. I'm fairly sure they are just flake, they've passed before, but I'll find out.
requires: | ||
- windows-build | ||
|
||
- create-build-artifacts: | ||
<<: *full-windows-workflow-filters | ||
name: windows-create-build-artifacts | ||
executor: windows | ||
resource_class: windows.medium | ||
resource_class: windows.xlarge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A little unsettling that we don't know why this is required, but glad to have windows CI back to green.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. 😕
@@ -32,9 +32,6 @@ import { | |||
} from '../sources/migration' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to clarify for reviewers: every file change below this line is reverted from #22118 and you don't need to review it to review this PR.
Hey @ryanthemanuel I do not think we need to revert #22118 anymore - can you just merge this commit and it'll be fine. I checked out #22118, merged this in, added that one commit, and pushed - CI is green. Link to CI run with 100% windows tests passing first run. |
User facing changelog
N/A
Additional details
The main goal here is to fix flaky tests in windows. This was accomplished via:
postFragment
subscriptionsNeither of these are ideal solutions; however, they don't appear to be new problems (I can recreate them in at least v10.0.3). Consequently we want to make the builds more stable and follow up on these issues later.
Steps to test
Check that CI succeeds
How has the user experience changed?
N/A
PR Tasks
cypress-documentation
?type definitions
?