-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement JIT component experiment #30049
Merged
Merged
Changes from 4 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
cd55330
feat: implement JIT component experiment [run ci]
AtofStryker 9d4900d
don't update the dev server unnecessarily if the run is cancelled [ru…
AtofStryker 31b8610
fix system test flake
AtofStryker 72df233
Update cli/types/cypress.d.ts
AtofStryker 30d7820
Update system-tests/projects/experimental-JIT/webpack/cypress/support…
AtofStryker fc30c45
Update system-tests/projects/experimental-JIT/vite/cypress/support/co…
AtofStryker 77b5dee
chore: ignore node_modules for webpack dev server
AtofStryker e4eaaf8
be sure to end span when throwing error
AtofStryker 2d29ed1
Merge branch 'feat/experimentalJustInTimeCompile' of github.com:cypre…
AtofStryker File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
42 changes: 42 additions & 0 deletions
42
packages/app/cypress/e2e/runner/runner-ct.experimentalJustInTimeCompile.cy.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
import type { fixtureDirs } from '@tooling/system-tests' | ||
|
||
type ProjectDirs = typeof fixtureDirs | ||
|
||
const EXPERIMENTAL_JIT_DIR: ProjectDirs[number] = 'experimental-JIT' | ||
|
||
const PROJECTS: {bundler: 'vite' | 'webpack'}[] = [ | ||
{ bundler: 'vite' }, | ||
{ bundler: 'webpack' }, | ||
] | ||
|
||
for (const { bundler } of PROJECTS) { | ||
const PROJECT_NAME = `${EXPERIMENTAL_JIT_DIR}/${bundler}` | ||
|
||
describe(`CT experimentalJustInTimeCompile: ${bundler}`, { viewportWidth: 1500, defaultCommandTimeout: 30000 }, () => { | ||
const visitComponentSpecAndVerifyPass = (specNumber: number) => { | ||
cy.contains(`Component-${specNumber}.cy.jsx`).click() | ||
cy.waitForSpecToFinish(undefined) | ||
cy.get('[aria-label="Stats"] .passed > .num').should('contain', '1') | ||
cy.get('[aria-label="Stats"] .failed > .num').should('contain', '--') | ||
} | ||
|
||
beforeEach(() => { | ||
// @ts-expect-error | ||
cy.scaffoldProject(PROJECT_NAME) | ||
cy.findBrowsers() | ||
}), | ||
|
||
it(`can run multiple CT tests without interruption`, () => { | ||
// @ts-expect-error | ||
cy.openProject(PROJECT_NAME, ['--component']) | ||
cy.startAppServer('component') | ||
cy.visitApp() | ||
cy.specsPageIsVisible() | ||
visitComponentSpecAndVerifyPass(2) | ||
cy.get('[data-cy="sidebar-link-specs-page"]').click() | ||
visitComponentSpecAndVerifyPass(1) | ||
cy.get('[data-cy="sidebar-link-specs-page"]').click() | ||
visitComponentSpecAndVerifyPass(3) | ||
}) | ||
}) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to watch everything? Or is there a smaller subset of files that we can watch in the JIT case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's actually doing the later. The watching only applies to files that are in the entry, which is the support file, index file and related files, plus the spec entry. I contemplated narrowing this down to just the specpattern, but we have this weird hack where we save the index file with no changes to prompt the dev server to trigger a refresh. I wonder if we can just do the index html file and we get the same effect? Ill try it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ryanthemanuel So the watch options for webpack are a bit complicated, but I figure a quick win here is to at least ignore the
node_modules
directory. Vite ignores this by default. updated watch options in 77b5dee