Address some visibility issues #4421

jennifer-shehane · 2019-06-10T08:20:42Z

Partially handles Element visibility fixes #1242
Closes Cypress fails when use should('be.visible') on a visible element - overflow hidden with position absolute outside #4395
Closes 'visible' assertion says visible for elements cropped by parent element with overflow: hidden #4161
Closes <option> should be considered visible if in visible select #4473
Closes <body> and <html> should always be considered visible #4475
Closes td and tr elements within visibility: collapse are considered visible - should be hidden #4476

… position absolute element. Addresses #4395

…ith el outside bounds Addresses #4161

Addresses #1178

Addresses #723

…r positioning attributes close #4395 close #755

…ow hidden would be calculated as not visible

- Add case to make sure display none is not on the option or optgroup itself

…iliyt

packages/driver/src/dom/visibility.js

freewind · 2019-06-21T11:03:49Z

@jennifer-shehane When will cypress release new versions? I have many tests blocked by this issue, hope to use it earlier

jennifer-shehane · 2019-06-24T15:32:48Z

@freewind As soon as we finish some changes that need to be part of this release to match our API. We have instructions now on how to install the pre-release if you'd like to try that. https://on.cypress.io/installing-cypress#Install-pre-release-version

Add failing test case for visible element within overflow hidden then…

76859ab

… position absolute element. Addresses #4395

jennifer-shehane changed the title ~~Address visibility issues~~ [WIP] Address visibility issues Jun 10, 2019

jennifer-shehane mentioned this pull request Jun 10, 2019

Cypress fails when use should('be.visible') on a visible element - overflow hidden with position absolute outside #4395

Closed

Write failing test case for when parent is flex and overflow hidden w…

af3eced

…ith el outside bounds Addresses #4161

jennifer-shehane mentioned this pull request Jun 10, 2019

'visible' assertion says visible for elements cropped by parent element with overflow: hidden #4161

Closed

Wrote failing test for visibility outside of clip-path

14f12ab

Addresses #1178

jennifer-shehane mentioned this pull request Jun 11, 2019

Elements hidden using clip / clip-path css properties pass as visible #1178

Closed

Add failing tests for transform scale

8a5a996

Addresses #723

jennifer-shehane mentioned this pull request Jun 11, 2019

.should("be.visible") doesn't interpet elements with " style='transform: scale(0,0)' " correctly #723

Closed

Add failing test for backfact-visibility hidden example

4d43b21

jennifer-shehane mentioned this pull request Jun 11, 2019

backface-visibility: hidden doesn't hide elements from cypress #2985

Closed

jennifer-shehane added 15 commits June 12, 2019 17:59

cs -> js fixes

79547b4

Add more specific error when el is not element

ddedae9

Always return as visible when checking html or body

80ea3c3

Add comments + rename methods to be more exact

0590d6e

Add case for isHidden when visibility is collapse

294c293

Add failing test cases for visibility issues

17e4be0

Add comment about how ensureVisibility works under the hood

62fa66e

Add checks and tests for opacity: 0 to be hidden

53d4441

Simplify if/case statements to be more readable

28185e9

Expand check for offset parents to also check children of ancestor fo…

ded5e9f

…r positioning attributes close #4395 close #755

Fix issue where els with parents with absolute position inside overfl…

e4df21a

…ow hidden would be calculated as not visible

comment out opacity checks for patch release

76edde5

Merge branch 'develop' into issue-1242

afc64a0

Add more tests around new visibility assertions

0dda9f5

- Add case to make sure display none is not on the option or optgroup itself

Fix failing assertion - where el was undefined when looking for visib…

7d514bb

…iliyt

jennifer-shehane changed the title ~~[WIP] Address visibility issues~~ Address some visibility issues Jun 17, 2019

jennifer-shehane requested a review from a team June 17, 2019 12:44

jennifer-shehane mentioned this pull request Jun 17, 2019

Opacity is not considered for visibility checks #4474

Closed

brian-mann requested changes Jun 17, 2019

View reviewed changes

packages/driver/src/dom/visibility.js Outdated Show resolved Hide resolved

remove commented out code involving opacity 😬

e123224

jennifer-shehane requested review from brian-mann and a team June 18, 2019 04:52

jennifer-shehane merged commit e2205f9 into develop Jun 19, 2019

This was referenced Jun 19, 2019

<option> should be considered visible if in visible select #4473

Closed

<body> and <html> should always be considered visible #4475

Closed

td and tr elements within visibility: collapse are considered visible - should be hidden #4476

Closed

jennifer-shehane mentioned this pull request Dec 17, 2019

Inability to determine reason for invisibility #5974

Closed

emilyrohrbough deleted the issue-1242 branch August 1, 2024 13:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Address some visibility issues #4421

Address some visibility issues #4421

jennifer-shehane commented Jun 10, 2019 •

edited

Loading

freewind commented Jun 21, 2019

jennifer-shehane commented Jun 24, 2019

Address some visibility issues #4421

Address some visibility issues #4421

Conversation

jennifer-shehane commented Jun 10, 2019 • edited Loading

freewind commented Jun 21, 2019

jennifer-shehane commented Jun 24, 2019

jennifer-shehane commented Jun 10, 2019 •

edited

Loading