Code

Address some visibility issues#4421

Code

Merged

jennifer-shehane merged 21 commits intodevelopcypress-io/cypress:developfrom issue-1242cypress-io/cypress:issue-1242Copy head branch name to clipboardJun 19, 2019

+616-271

Commits

Commits on Jun 10, 2019

• Add failing test case for visible element within overflow hidden then position absolute element.

  Show description for 76859ab
  jennifer-shehane

  committed
  76859ab

  Copy full SHA for 76859ab

• Write failing test case for when parent is flex and overflow hidden with el outside bounds

  Show description for af3eced
  jennifer-shehane

  committed
  af3eced

  Copy full SHA for af3eced

Commits on Jun 11, 2019

• Wrote failing test for visibility outside of clip-path

  Show description for 14f12ab
  jennifer-shehane

  committed
  14f12ab

  Copy full SHA for 14f12ab

• Add failing tests for transform scale

  Show description for 8a5a996
  jennifer-shehane

  committed
  8a5a996

  Copy full SHA for 8a5a996

• Add failing test for backfact-visibility hidden example

  jennifer-shehane

  committed
  4d43b21

  Copy full SHA for 4d43b21

Commits on Jun 12, 2019

• cs -> js fixes

  jennifer-shehane

  committed
  79547b4

  Copy full SHA for 79547b4

• Add more specific error when el is not element

  jennifer-shehane

  committed
  ddedae9

  Copy full SHA for ddedae9

• Always return as visible when checking html or body

  jennifer-shehane

  committed
  80ea3c3

  Copy full SHA for 80ea3c3

• Add comments + rename methods to be more exact

  jennifer-shehane

  committed
  0590d6e

  Copy full SHA for 0590d6e

• Add case for isHidden when visibility is collapse

  jennifer-shehane

  committed
  294c293

  Copy full SHA for 294c293

• Add failing test cases for visibility issues

  jennifer-shehane

  committed
  17e4be0

  Copy full SHA for 17e4be0

Commits on Jun 14, 2019

• Add comment about how ensureVisibility works under the hood

  jennifer-shehane

  committed
  62fa66e

  Copy full SHA for 62fa66e

• Add checks and tests for opacity: 0 to be hidden

  jennifer-shehane

  committed
  53d4441

  Copy full SHA for 53d4441

Commits on Jun 17, 2019

• Simplify if/case statements to be more readable

  jennifer-shehane

  committed
  28185e9

  Copy full SHA for 28185e9

• Expand check for offset parents to also check children of ancestor for positioning attributes

  Show description for ded5e9f
  jennifer-shehane

  committed
  ded5e9f

  Copy full SHA for ded5e9f

• Fix issue where els with parents with absolute position inside overflow hidden would be calculated as not visible

  jennifer-shehane

  committed
  e4df21a

  Copy full SHA for e4df21a

• comment out opacity checks for patch release

  jennifer-shehane

  committed
  76edde5

  Copy full SHA for 76edde5

• Merge branch 'develop' into issue-1242

  jennifer-shehane

  committed
  afc64a0

  Copy full SHA for afc64a0

• Add more tests around new visibility assertions

  Show description for 0dda9f5
  jennifer-shehane

  committed
  0dda9f5

  Copy full SHA for 0dda9f5

• Fix failing assertion - where el was undefined when looking for visibiliyt

  jennifer-shehane

  committed
  7d514bb

  Copy full SHA for 7d514bb

Commits on Jun 18, 2019

• remove commented out code involving opacity 😬

  jennifer-shehane

  committed
  e123224

  Copy full SHA for e123224