Skip to content

Commit

Permalink
Pin around pydantic 1.10.7 (#14437)
Browse files Browse the repository at this point in the history
This removes the pin introduced in:

#14407

Because pydantic has now fixed the underlying cause. Instead, we'll pin
around the affected version of pydantic.
  • Loading branch information
jmsanders authored and odette-elementl committed Jun 1, 2023
1 parent 4407182 commit a3a8a0b
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 3 deletions.
2 changes: 2 additions & 0 deletions examples/with_great_expectations/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@
"dagster",
"dagster-ge",
"great_expectations>=0.14.12", # pinned because pip is using the cached wheel for 0.13.14
# https://github.com/great-expectations/great_expectations/issues/7990
"typing_extensions<4.6.0",
],
extras_require={"dev": ["dagit", "pytest"]},
)
5 changes: 3 additions & 2 deletions python_modules/dagster/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ def get_version() -> str:
"tabulate",
"tomli",
"tqdm",
"typing_extensions>=4.4.0,<4.6.0",
"typing_extensions>=4.4.0",
"sqlalchemy>=1.0,<2.0.0",
"toposort>=1.0",
"watchdog>=0.8.3",
Expand All @@ -100,7 +100,8 @@ def get_version() -> str:
'pywin32 != 226; platform_system=="Windows"',
"docstring-parser",
"universal_pathlib",
"pydantic",
# https://github.com/pydantic/pydantic/issues/5821
"pydantic != 1.10.7",
],
extras_require={
"docker": ["docker"],
Expand Down
6 changes: 6 additions & 0 deletions python_modules/libraries/dagster-ge/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,5 +37,11 @@ def get_version() -> str:
"pandas",
"great_expectations >=0.11.9, !=0.12.8, !=0.13.17, !=0.13.27",
],
extras_require={
"test": [
# https://github.com/great-expectations/great_expectations/issues/7990
"typing_extensions<4.6.0",
],
},
zip_safe=False,
)
2 changes: 1 addition & 1 deletion python_modules/libraries/dagster-ge/tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ deps =
-e ../dagster-pandas
-e ../dagster-spark
-e ../dagster-pyspark
-e .
-e .[test]
allowlist_externals =
/bin/bash
commands =
Expand Down

0 comments on commit a3a8a0b

Please sign in to comment.