Pin typing_extensions < 4.6.0 #14407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest release of typing_extensions breaks great expectations. Great expectations is already pinned but hasn't release a new version yet: great-expectations/great_expectations#7974 (comment) Pydantic and typing extensions are aware of and working on fixes as well: python/typing_extensions#179 pydantic/pydantic#5821 Until all those pins/fixes land, let's introduce our own pins to keep our builds passing.
rexledesma
approved these changes
May 23, 2023
|
Not just great expectations I think?
https://dagster.slack.com/archives/C02LJ7G0LAZ/p1684811648474309
…On Tue, May 23, 2023 at 8:38 AM Jordan Sanders ***@***.***> wrote:
@jmsanders <https://github.com/jmsanders> requested your review on: #14407
<#14407> Pin typing_extensions
< 4.6.0.
—
Reply to this email directly, view it on GitHub
<#14407 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACAPJC7QXIOKY44F6RPVVE3XHS4V7ANCNFSM6AAAAAAYL5J3JA>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
Maybe just pin it in |
|
Interesting that this is the only place it impacts us in our build, but yeah, I agree we should just broadly pin (until a fix is available - might be a moot point - I suspect everything will be cleared up by the time we release this week). I'll elevate the pin and close the other PR I just opened that fixes our internal builds. |
The primary motivation here is to fix our tests because it looks like upstream projects are working on their own fixes. If Thursday's release comes and a fix still isn't available, we'll ship with this pin. But I'd prefer if we could remove this before then. In the meantime, users who encounter the issue can fix by pinning typing_expectations < 4.6.0.
jmsanders
added a commit
that referenced
this pull request
May 24, 2023
This removes the pin introduced in: #14407 Because pydantic has now fixed the underlying cause. Instead, we'll pin around the affected version of pydantic.
jmsanders
added a commit
that referenced
this pull request
May 25, 2023
This removes the pin introduced in: #14407 Because pydantic has now fixed the underlying cause. Instead, we'll pin around the affected version of pydantic.
jmsanders
added a commit
that referenced
this pull request
May 25, 2023
odette-elementl
pushed a commit
that referenced
this pull request
Jun 1, 2023
The latest release of typing_extensions breaks great expectations. Great expectations is already pinned but hasn't release a new version yet: great-expectations/great_expectations#7974 (comment) Pydantic and typing extensions are aware of and working on fixes as well: python/typing_extensions#179 pydantic/pydantic#5821 Until all those pins/fixes land, let's introduce our own pins to keep our builds passing.
odette-elementl
pushed a commit
that referenced
this pull request
Jun 1, 2023
This removes the pin introduced in: #14407 Because pydantic has now fixed the underlying cause. Instead, we'll pin around the affected version of pydantic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest release of typing_extensions breaks great expectations.
Great expectations is already pinned but hasn't release a new version yet:
great-expectations/great_expectations#7974 (comment)
Pydantic and typing extensions are aware of and working on fixes as well:
python/typing_extensions#179 pydantic/pydantic#5821
Until all those pins/fixes land, let's introduce our own pins to keep our builds passing.