-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modify the logic about removing or adding slides dynamically #103
Conversation
zhouqiangWang
commented
May 8, 2015
- Disable slide (not autocycle) when theres only one image? Disable slide (not autocycle) when theres only one image? #82 …
- Modify PagerIndicator show wrong numbers of indicators when call removeSliderAt
- modify ViewPager scroll logic when SliderAdapter data change. avoid slide around a bunch on initializing after removing or adding slides dynamically
1. revert last modification 6bb1164 2. add Indicator.redraw() logic in removeSliderAt 3. add add and delete pager menu for test.
merge from daimajia-master
please help to review this modification. Actually, there is one more issue about sliding around a bunch sliders after removing or adding dynamically. Now I just disable the smooth animation but it will display blank sometimes. |
@zhouqiangWang This pull request can not merge automatically, you need to pull the latest code, solve the conflict and then re-push it. |
conflict resolved. |
When there is only one image slider, it's still cycling. |
I tried it. unless you scroll some. triggered |
@zhouqiangWang Still buggy:
|