Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix demo to prevent memory leak on device orientation change #104

Merged
merged 1 commit into from
May 9, 2015
Merged

Fix demo to prevent memory leak on device orientation change #104

merged 1 commit into from
May 9, 2015

Conversation

massimobio
Copy link
Contributor

This is as recommended in #41
I verified that the leak is fixed with this change.
I also updated the wiki: https://github.com/daimajia/AndroidImageSlider/wiki/Start-Using

@massimobio
Copy link
Contributor Author

@zhouqiangWang I was just looking at your #103
Does the code in destroySelf() do the same as this fix?
If yes, I'll close this and undo the changes in the wiki.

@daimajia
Copy link
Owner

daimajia commented May 9, 2015

@massimobio There are still some problems exists in #103, I'll merge this pull request firstly.

daimajia added a commit that referenced this pull request May 9, 2015
Fix demo to prevent memory leak on device orientation change fix #41
@daimajia daimajia merged commit 323a43f into daimajia:master May 9, 2015
@massimobio
Copy link
Contributor Author

@daimajia ok, thank you. I'll keep an eye on #103 and see how it develops. If I understand correctly, the destroySelf() method does the same thing as this PR but doesn't require the user to add the extra code, so it might be a cleaner solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants