Skip to content

Commit

Permalink
don't re-show message after auto-hide
Browse files Browse the repository at this point in the history
  • Loading branch information
danielnaber committed Jul 15, 2015
1 parent 657479e commit dad33a0
Showing 1 changed file with 16 additions and 1 deletion.
17 changes: 16 additions & 1 deletion data/js/contentScript.js
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,13 @@ function removeDisabledLanguages(detectableLanguages)

function showFeedback(element, feedbackText, feedbackTitle, isWarning)
{

if (feedbackDiv.textContent === feedbackText)
{
// don't always show the same feedback after is has been hidden
return;
}

// Detach the feedback div from the document if it were previously attached
if(feedbackDiv.parentElement)
feedbackDiv.parentElement.removeChild(feedbackDiv);
Expand Down Expand Up @@ -249,7 +256,12 @@ function showFeedback(element, feedbackText, feedbackTitle, isWarning)
let feedbackHideSeconds = userPreferences["feedbackHideSeconds"] * 1000;
// TODO: not robust enough yet:
//feedbackTimeout = setTimeout(function() {fadeOut(feedbackDiv)}, feedbackHideSeconds);
feedbackTimeout = setTimeout(function() {feedbackDiv.parentElement.removeChild(feedbackDiv)}, feedbackHideSeconds);
feedbackTimeout = setTimeout(function() {
if (feedbackDiv.parentElement)
{
feedbackDiv.parentElement.removeChild(feedbackDiv);
}
}, feedbackHideSeconds);
}
}

Expand All @@ -263,6 +275,7 @@ function fadeOut(el)
if (feedbackDiv.parentElement)
{
feedbackDiv.parentElement.removeChild(feedbackDiv);
feedbackDiv.textContent = feedBackWaitText;
el.style.opacity = 1;
}
}
Expand Down Expand Up @@ -334,6 +347,8 @@ document.documentElement.addEventListener("blur", function (evt)
// When the focus gets out of an element, detach the feedback div from the document
if(feedbackDiv.parentElement)
feedbackDiv.parentElement.removeChild(feedbackDiv);
// when user enters field later, feedback will be shown again:
feedbackDiv.textContent = feedBackWaitText;
}, true);

document.documentElement.addEventListener("paste", function (e)
Expand Down

0 comments on commit dad33a0

Please sign in to comment.