Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switching focus fast sometimes doesn't trigger spell check #7

Open
danielnaber opened this issue Jul 13, 2015 · 7 comments
Open

switching focus fast sometimes doesn't trigger spell check #7

danielnaber opened this issue Jul 13, 2015 · 7 comments
Assignees
Labels

Comments

@danielnaber
Copy link
Owner

If you have a textarea with English text and one with German text and you switch between them very fast (just by clicking in inside), sometimes the language gets detected, but the spell checker doesn't update, e.g. the German text stays underlined.

@danielnaber
Copy link
Owner Author

Same when clicking in a textarea directly after page load.

@danielnaber
Copy link
Owner Author

Improved but not fixed by using setTimeout.

@ashrafsabrym
Copy link
Contributor

How to reproduce this problem? Did it happen on a certain website?

@danielnaber
Copy link
Owner Author

I can reproduce with my test.html. Reload page, click in German text field -> German detected but still everything underlined. Doesn't happen every time though.

@ashrafsabrym
Copy link
Contributor

I can't reproduce this problem. I even removed the setTimeout call, and still the problem doesn't happen.
This may be caused by a JavaScript problem that occurs before this part in changeDictionary that sets the dictionary language. If the problem occurs so often, then please run the addon in debug mode and do the steps that causes the problem. When it happen, look at the console and see if there's any thrown JavaScript errors.

@danielnaber
Copy link
Owner Author

I always (no matter if the problem occurs) get a deprecation warning that tells me to use defaultPrevented instead of getPreventDefault(). Not sure what that refers to. The source of the message is just test.html with no line number. I don't get any other errors or warnings.

@ashrafsabrym
Copy link
Contributor

The deprecation warning is caused by jQuery. It's not caused by our code.
Seems that this problem will be hard to discover.

This may be weird, but why not this is caused by the dictionaries themselves or Firefox spell checking service?

danielnaber added a commit that referenced this issue Jul 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants