Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config: Customize default export folder (Both Normal Export & Quick Export) #58

Closed
dark-person opened this issue Mar 4, 2024 · 0 comments · Fixed by #114
Closed

Config: Customize default export folder (Both Normal Export & Quick Export) #58

dark-person opened this issue Mar 4, 2024 · 0 comments · Fixed by #114
Labels
enhancement[unused] Improvement of Existing Feature
Milestone
v0.8.0

Comments

@dark-person
Copy link
Owner

dark-person commented Mar 4, 2024 •
edited
Loading

Support user to choose directory that output:

  • .cbz file
  • .cbz file that wrapped with folder

If user keep blank for this setting, then default setting will be used (export inside image directory). This will be handle by proposal in issue #63

Config Proposal

Provide a new config value:

  • comic_directory_standard: Apply to normal generate process
  • comic_directory_quick : Apply to Quick Export ONLY

Notes

Consider allow user to define multiple comic_directory_standard from config, while comic_directory_quick must be ONE only.
@dark-person dark-person added this to the v0.4.0 milestone Mar 4, 2024
@dark-person dark-person added the enhancement[unused] Improvement of Existing Feature label Mar 4, 2024
@dark-person dark-person changed the title Support custom export location of Quick Export & Normal Export Config: Customize default export folder (Both Normal Export & Quick Export) Mar 9, 2024
@dark-person dark-person modified the milestones: v0.4.0, v0.5.0 Mar 9, 2024
@dark-person dark-person removed this from the v0.5.0 milestone Mar 30, 2024
@dark-person dark-person added this to the v0.7.0 milestone Aug 3, 2024
@dark-person dark-person modified the milestones: v0.7.0, Backlog, v0.8.0 Oct 27, 2024
@dark-person dark-person mentioned this issue Dec 1, 2024
Merged
8 tasks
dark-person added a commit that referenced this issue Dec 1, 2024
@dark-person
Allow custom default export directory by config (#113)
9b392e5 
### Changes (New Feature)

- Use `koanf` as config package
- Allow user to define default export folder by `config.yaml` 
- Update gitignore and docs

### Related Issues

This change can solve 1st part of issue #58.
@dark-person dark-person mentioned this issue Dec 1, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement[unused] Improvement of Existing Feature
Projects
None yet
Milestone
v0.8.0
Development

Successfully merging a pull request may close this issue.

Use default export folder in quick export dark-person/ComicInfo-Parser
1 participant
@dark-person