Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom default export directory by config #113

Merged
merged 4 commits into from
Dec 1, 2024

Conversation

dark-person
Copy link
Owner

@dark-person dark-person commented Dec 1, 2024

Changes (New Feature)

  • Use koanf as config package
  • Allow user to define default export folder by config.yaml
  • Update gitignore and docs

Related Issues

This change can solve 1st part of issue #58.

Checklist:

Code Checklist:

  • I have run the new code and ensure the change is work expected
  • I have write/modify comments to important function & hard-to-understand code
  • I have checked my code has no misspellings & no warnings
  • I have checked that only essential code remains in this pull request

Documentation Checklist:

  • I have add new feature description to README.md of this repository
  • I have add/modify file description to README.md of the package (tick if not applicable)

Testing Checklist:

  • I have create new test case / test for new feature
  • I have run all new & existing test and pass locally with my changes

@dark-person dark-person added this to the v0.8.0 milestone Dec 1, 2024
@dark-person dark-person marked this pull request as ready for review December 1, 2024 08:57
@dark-person dark-person merged commit 9b392e5 into master Dec 1, 2024
3 checks passed
@dark-person dark-person deleted the feat/config/default-export branch December 1, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant