This repository has been archived by the owner on Jan 6, 2025. It is now read-only.
Support shutting down the handler ignoring any keepAlive periods #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is for application-initiated shutdowns (for ex. hitting Ctrl+C in the terminal of a running server).
|
This fix might not be complete... The test passes, but in webdev it still hangs (possibly due to the timers not being cancelled)... will look for a way to fix. |
|
(ok, this seems to work now) |
|
@jakemac53 @grouma ping! |
|
Let's get a changelog and version update and I'll publish. Otherwise LGTM. |
|
Done, thanks! |
grouma
reviewed
Apr 23, 2020
test/sse_test.dart
Outdated
| // Close the underlying connection. | ||
| handler.shutdown(); | ||
|
|
||
| // The isInKeepAlivePeriod flag may only be set for a short period because |
There was a problem hiding this comment.
This comment no longer makes sense.
mosuem
pushed a commit
to dart-lang/tools
that referenced
this pull request
Dec 10, 2024
…t-archive/sse#27) * Support shutting down the handler ignoring any keepAlive periods
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we need something like this in order to fix dart-lang/webdev#950. The issue is that the keepAlive period fires for the injected client handler and prevents the daemon from ending until the keepAlive timer runs out.
This exposes a
shutdownmethod on the handler that will close all connections ignoring the keepAlive.