Daemon doesn't quit when sent SIGINT/SIGTERM

[DanTup]

If I run a project with pub global run webdev serve and hit Ctrl+C (in my macOS terminal), it quits fine. However if I do the same for pub global run webdev daemon, it doesn't quit. I think this worked in the past, as it's causing some of Dart-Code's integration tests to fail.

pub global run webdev daemon
[{"event":"daemon.connected","params":{"version":"0.4.2","pid":18408}}]
[{"event":"daemon.log","params":{"log":"[INFO] Connecting to the build daemon..."}}]
[{"event":"daemon.log","params":{"log":"[INFO] Generating build script..."}}]
[{"event":"daemon.log","params":{"log":"[INFO] Generating build script completed, took 280ms"}}]
[{"event":"daemon.log","params":{"log":"[INFO] "}}]
[{"event":"daemon.log","params":{"log":"[INFO] Starting daemon..."}}]
[{"event":"daemon.log","params":{"log":"[INFO] Initializing inputs"}}]
// Trim boring stuff

Then I hit Ctrl+C and see:

^C[{"event":"app.log","params":{"appId":"Zx8LtUMQv8Vik6vK2PDePw==","log":"Lost connection to device."}}]
[{"event":"app.stop","params":{"appId":"Zx8LtUMQv8Vik6vK2PDePw=="}}]
[{"event":"daemon.log","params":{"log":"[INFO] Stopped debug service on ws://127.0.0.1:59201\n"}}]

However, it then continues to sit there and does not terminate (it does close the browser window though).

The app I'm testing with is here:

https://github.com/Dart-Code/Dart-Code/tree/master/src/test/test_projects/web/hello_world

I'm using a globally activated v2.5.6 of webdev.

[jakemac53]

this might be related to some of the SSE stuff if we still have a connection open

[DanTup]

Yeah, removing keepAlive seems to stop this. I'll see if I can find a fix!

[DanTup]

I've opened a PR in SSE that I think will address this:

dart-archive/sse#27

It exposes a shutdown() method on the SseHandler that can be called from the shutdown code here, to ensure all connections are closed (ignoring their keepAlives).

[DanTup]

Using the code in that PR, this is the change I believe should be made here to call it (it fixes the issue in my brief testing):

I'm not sure whether the code I've removed/commented here can be completely replaced though (and whether the comment should be kept/how it should be updated).

[DanTup]

@grouma oops, my bad comment in that other PR caused this to close, but we still need changes here to call shutdown.

[grouma]

Feel free to send a PR and I'll reopen.

…

On Thu, Apr 23, 2020, 1:36 PM Danny Tuppeny ***@***.***> wrote: @grouma <https://github.com/grouma> oops, my bad comment in that other PR caused this to close, but we still need changes here to call shutdown. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#950 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAOBNBN2QW2JUXFVXOK3273ROCRGRANCNFSM4MD5WTDA> .