This repository has been archived by the owner on Jan 6, 2025. It is now read-only.
Add package:js to dependencies
#71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natebosch
reviewed
Dec 14, 2022
pubspec.yaml
Outdated
| @@ -18,6 +18,7 @@ dependencies: | |||
| stream_channel: '>=1.6.8 <3.0.0' | |||
|
|
|||
| dev_dependencies: | |||
| js: ^0.6.4 | |||
There was a problem hiding this comment.
This is used under lib/, so it should be in dependencies instead of dev_dependencies
elliette
changed the title
package:js to dev dependenciespackage:js to dependencies
grouma
approved these changes
Dec 14, 2022
mosuem
pushed a commit
to dart-lang/tools
that referenced
this pull request
Dec 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following error when I went to publish
package:sse:Also updates the min Dart SDK to 2.16.0 for version compatibility with
package:js