Skip to content
This repository has been archived by the owner on Jan 6, 2025. It is now read-only.

Add package:js to dependencies #71

Merged
merged 7 commits into from
Dec 14, 2022
Merged

Add package:js to dependencies #71

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
32d62b3
Add package:js to dependencies
elliette Dec 14, 2022
734b9ad
Also update SDK version
elliette Dec 14, 2022
9777726
Older version of package:js
elliette Dec 14, 2022
caad2cf
Update min SDK and versions we test against in CI
elliette Dec 14, 2022
84b5954
Update CHANGELOG
elliette Dec 14, 2022
0c92828
Move package:js to dependencies
elliette Dec 14, 2022
6ce9e6b
Update CHANGELOG
elliette Dec 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/test-package.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
strategy:
fail-fast: false
matrix:
sdk: [dev]
sdk: [stable, dev]
steps:
- uses: actions/checkout@93ea575cb5d8a053eaa0ac8fa3b40d7e05a33cc8
- uses: dart-lang/setup-dart@6a218f2413a3e78e9087f638a238f6b40893203d
Expand All @@ -47,7 +47,7 @@ jobs:
matrix:
# Add macos-latest and/or windows-latest if relevant for this package.
os: [ubuntu-latest]
sdk: [2.15.0, dev]
sdk: [stable, dev]
steps:
- uses: actions/checkout@93ea575cb5d8a053eaa0ac8fa3b40d7e05a33cc8
- uses: dart-lang/setup-dart@6a218f2413a3e78e9087f638a238f6b40893203d
Expand Down
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

- Send `fetch` requests instead of `XHR` requests.
- Add an optional `debugKey` parameter to `SseClient` to include in logging.
- Add a dev dependency on `package:js`.
- Update the minimum Dart SDK version to `2.16.0`.

## 4.1.1

Expand Down
3 changes: 2 additions & 1 deletion pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ description: >-
repository: https://github.com/dart-lang/sse

environment:
sdk: '>=2.15.0 <3.0.0'
sdk: '>=2.16.0 <3.0.0'

dependencies:
async: ^2.0.8
Expand All @@ -18,6 +18,7 @@ dependencies:
stream_channel: '>=1.6.8 <3.0.0'

dev_dependencies:
js: ^0.6.4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is used under lib/, so it should be in dependencies instead of dev_dependencies

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, thank you!

lints: ^1.0.0
shelf_static: '>=0.2.8 <2.0.0'
test: ^1.5.3
Expand Down