Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DevTools extensions detection logic fails to work in workspaces #4379

Closed
kenzieschmoll opened this issue Sep 11, 2024 · 5 comments
Closed

DevTools extensions detection logic fails to work in workspaces #4379

kenzieschmoll opened this issue Sep 11, 2024 · 5 comments
Labels
type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@kenzieschmoll
Copy link

flutter/devtools#7944

@sigurdm
Copy link
Contributor

sigurdm commented Sep 12, 2024

I'm not really sure there's much we can do from the pub client side.

I can try to investigate the dtd side of this. Around https://github.com/dart-lang/sdk/blob/ba8306735d7efa8aabfbf4d8f9a618bd00bfbcbd/pkg/dtd_impl/lib/src/service/file_system_service.dart#L204 But I'm not sure I have the best context for making changes there.

@bkonyi and @CoderDake might want to give a comment.

@sigurdm sigurdm changed the title Pub workspaces will break DevTools extensions detection logic DevTools extensions detection logic fails to work in workspaces Sep 12, 2024
@sigurdm
Copy link
Contributor

sigurdm commented Sep 12, 2024

I updated the title, as strictly speaking we don't break anything in existing (non-workspace) projects

@bkonyi
Copy link
Contributor

bkonyi commented Sep 12, 2024

I think I'll need more context to really understand what the issue here is and what we need to resolve it. Then either @derekxu16 or I can dig into it (@CoderDake is no longer at Google).

@kenzieschmoll
Copy link
Author

The underlying issue here is #4218. I created this issue as a tracking issue for the "Shipping Pub Workspaces" project since I couldn't add flutter/devtools#7944 directly.

@sigurdm sigurdm added the type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) label Sep 26, 2024
@sigurdm sigurdm closed this as completed Oct 8, 2024
@sigurdm
Copy link
Contributor

sigurdm commented Oct 8, 2024

This was fixed in flutter/devtools#8347

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Development

No branches or pull requests

3 participants