Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support DevTools extension detection for pub workspaces #7944

Closed
kenzieschmoll opened this issue Jun 18, 2024 · 0 comments · Fixed by #8347
Closed

Support DevTools extension detection for pub workspaces #7944

kenzieschmoll opened this issue Jun 18, 2024 · 0 comments · Fixed by #8347
Assignees
@kenzieschmoll
Labels
devtools extensions Issues related to DevTools extensions P1 high priority issues at the top of the work list, actively being worked on.

Comments

@kenzieschmoll
Copy link
Member

For DevTools extensions, we currently assume that the .dart_tool/package_config.json file will always live in the project root. This may not be true for pub workspaces AKA monorepos.

What we should instead do is modify the DevTools server extension APIs to take the path to the package config file instead of the project root.

Related:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kenzieschmoll kenzieschmoll

Labels
devtools extensions Issues related to DevTools extensions P1 high priority issues at the top of the work list, actively being worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Find .dart_tool/package_config.json by looking in parent directories sigurdm/devtools
1 participant
@kenzieschmoll