Find .dart_tool/package_config.json by looking in parent directories #8347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PTAL |
packages/devtools_shared/lib/src/extensions/extension_manager.dart
Outdated
Show resolved
Hide resolved
| @@ -666,7 +668,7 @@ class ServiceManager<T extends VmService> { | |||
| dtd: dtdManager.connection.value, | |||
| ) | |||
| : null; | |||
| _log.fine('rootPackageDirectoryForMainIsolate: $packageUriString'); | |||
| _log.shout('rootPackageDirectoryForMainIsolate: $packageUriString'); | |||
There was a problem hiding this comment.
can you change this back to fine? We don't want this printing to console at the default log level
packages/devtools_shared/lib/src/extensions/extension_manager.dart
Outdated
Show resolved
Hide resolved
|
Thanks for patient and thorough reviews! |
kenzieschmoll
approved these changes
Sep 30, 2024
|
Can you try merging with the master to branch to see if that will fix the broken integration test? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #7944 and dart-lang/pub#4379
Ideally I think the VM (or perhaps DTD) should provide the packageConfigUri somehow (I filed dart-lang/sdk#56784) Trying to find it from the main-lib seems fragile.
I don't know if the extension loader does deduplication somewhere. But with this change we will discover extensions from the package config once for every project in the workspace.