Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support --package-root option #3036

Closed
kasperl opened this issue May 14, 2012 · 4 comments
Closed

Support --package-root option #3036

kasperl opened this issue May 14, 2012 · 4 comments
Assignees
@peter-ahe-google
Labels
web-dart2js

Comments

@kasperl
Copy link

kasperl commented May 14, 2012

We need to be able to resolve URIs that use the package: scheme. This means that we should be able to set the package root from the command line using the --package-root option (supported by the VM and frog).

If the package root isn't explicitly set it should default to

   "${dirname(script)}/packages"

where script is main Dart file we've been asked to compile. When resolving a URI that uses the package: scheme, we simply add the package root as the prefix (I guess this only makes sense for relative URLs).
@DartBot
Copy link

DartBot commented May 14, 2012

This comment was originally written by [email protected]

@peter-ahe-google
Copy link
Contributor

Set owner to @peter-ahe-google.
Added Accepted label.

@peter-ahe-google
Copy link
Contributor

Added Started label.

@peter-ahe-google
Copy link
Contributor

Committed as http://code.google.com/p/dart/source/detail?r=7849

But see issue #3170 and issue #3168 regarding tests.

Added Fixed label.

dart-bot pushed a commit that referenced this issue Jul 9, 2021
@jonasfj
Bump pub.
1b3b8f8 
New commits include:
```
git log --format="%C(auto) %h %s"
3c14d86a67db7207bbc9f654ac49ee60e08e5240..d159e5b9f04a7e4826b6afea7b3364d48aa0dad8
 d159e5b9 Validate and normalize hosted url. (#3030)
 12411d60 fail CI on info level issues; fix directives sorting (#3036)
 ab41ef0a Downgraded does_not_include_dot_file.dart to 2.10 (#3027)
```

Change-Id: I58e11393c5d6099406d3ba1884f69768395c7a0f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/206364
Reviewed-by: William Hesse <[email protected]>
Commit-Queue: William Hesse <[email protected]>
Auto-Submit: Jonas Jensen <[email protected]>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peter-ahe-google peter-ahe-google

Labels
web-dart2js
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kasperl @peter-ahe-google @DartBot