-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please test --package-root #3170
Comments
This should include testing stuff like issue #3147. |
Can you use --special-command for this? |
I don't think so. I need to write a few tests with different --package-root arguments, not run the test suite N times with different command-line arguments. |
This comment was originally written by [email protected] One test case from me: but Windows7, Dart 13122 For the sake of completeness, Adder.dart: #library('mylib'); void main() { |
Removed this from the 1.6 milestone. |
Removed Oldschool-Milestone-1.6 label. |
I imagine the CFE is sufficient here. |
Changes: ``` > git log --format="%C(auto) %h %s" 37d0592..0764437 https://dart.googlesource.com/pub.git/+/07644370 Make gitignore validator use gitignores from repo-root and down. (#3169) https://dart.googlesource.com/pub.git/+/205ea58c Handle build-versions when reformatting ranges (#3170) https://dart.googlesource.com/pub.git/+/8f7bfb8c migrate 3 leaf files to null-safety (#3168) https://dart.googlesource.com/pub.git/+/df5db1f1 Extract some parts of pubspec parsing to a null-safe library. (#3160) ``` Diff: https://dart.googlesource.com/pub.git/+/37d05928939b3100e7e55c3dff922651db1de1e1~..0764437088fd58eb7af779ecef66bab40dfcf2e9/ Change-Id: I8d938dbf6c3fba3c3f4d98bbaa5835acfaf132a7 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/216020 Reviewed-by: Sarah Zakarias <[email protected]> Commit-Queue: Sigurd Meldgaard <[email protected]>
We need a test of the --package-root command line.
The text was updated successfully, but these errors were encountered: