Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge 6.9.5 to master #1517

Merged
merged 11 commits into from
Oct 17, 2020
Merged

Merge 6.9.5 to master #1517

merged 11 commits into from
Oct 17, 2020

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Oct 17, 2020

No description provided.

mxgrey and others added 10 commits April 20, 2020 17:18
* DARTFindBullet: set CMP0057 to new

The IN_LIST keyword in DARTFindBullet caused a configuration
error in gazebo10. Setting CMP0057 to new should prevent
similar problems in downstream packages.

* Use approach from #1434
# Conflicts:
#	.appveyor.yml
#	.azure-pipelines.yml
#	.ci/install_linux.sh
#	.ci/install_osx.sh
#	.ci/script.sh
#	.ci/travis/docs_versions.txt
#	Brewfile
#	CHANGELOG.md
#	CMakeLists.txt
#	dart/dynamics/Skeleton.hpp
#	dart/dynamics/detail/GenericJoint.hpp
#	dart/optimizer/ipopt/CMakeLists.txt
#	dart/optimizer/ipopt/IpoptSolver.cpp
#	dart/optimizer/ipopt/IpoptSolver.hpp
#	package.xml
#	unittests/regression/test_Issue1445.cpp
@jslee02 jslee02 added this to the DART 6.10.0 milestone Oct 17, 2020
@codecov
Copy link

codecov bot commented Oct 17, 2020

Codecov Report

Merging #1517 into master will decrease coverage by 1.14%.
The diff coverage is 72.22%.

@@            Coverage Diff             @@
##           master    #1517      +/-   ##
==========================================
- Coverage   58.17%   57.02%   -1.15%     
==========================================
  Files         414      366      -48     
  Lines       30008    27145    -2863     
==========================================
- Hits        17456    15479    -1977     
+ Misses      12552    11666     -886     
Impacted Files Coverage Δ
dart/collision/CollisionResult.cpp 70.73% <0.00%> (ø)
dart/dynamics/Skeleton.hpp 83.33% <ø> (ø)
dart/optimizer/ipopt/IpoptSolver.cpp 74.10% <70.96%> (ø)
dart/dynamics/Skeleton.cpp 65.97% <100.00%> (-0.25%) ⬇️
dart/dynamics/detail/GenericJoint.hpp 74.87% <100.00%> (-0.60%) ⬇️
dart/dynamics/detail/ScrewJointAspect.hpp 60.00% <0.00%> (-40.00%) ⬇️
...art/dynamics/detail/TranslationalJoint2DAspect.cpp 28.78% <0.00%> (-25.06%) ⬇️
dart/dynamics/WeldJoint.cpp 67.85% <0.00%> (-18.81%) ⬇️
dart/collision/fcl/BackwardCompatibility.cpp 75.00% <0.00%> (-12.50%) ⬇️
dart/utils/sdf/SdfParser.cpp 65.47% <0.00%> (-11.26%) ⬇️
... and 282 more

@jslee02 jslee02 marked this pull request as ready for review October 17, 2020 23:09
@jslee02 jslee02 merged commit 85a9b49 into master Oct 17, 2020
@jslee02 jslee02 deleted the 6.9.5_to_master branch October 17, 2020 23:09
scpeters added a commit to scpeters/dart that referenced this pull request Oct 27, 2020
reverted two changes to make patch easier to apply

Co-authored-by: Grey <[email protected]>
Co-authored-by: Steve Peters <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants