fix(build): Fix E2E tests #1526

benjamingeer · 2019-11-20T15:56:09Z

subotic · 2019-11-20T16:10:20Z

webapi/src/it/scala/org/knora/webapi/ITKnoraLiveSpec.scala

-
-
-    protected def singleAwaitingRequest(request: HttpRequest, duration: Duration = 5999.milliseconds): HttpResponse = {
+    protected def singleAwaitingRequest(request: HttpRequest, duration: Duration = 7999.milliseconds): HttpResponse = {


Just in case you wonder why this odd number. It is easier to find the correct setting that needs to be tweaked. The timeout output is often not clear where it happened.

tobiasschweizer · 2019-11-20T16:23:40Z

webapi/src/test/resources/test-data/resourcesR2RV2/Testding.jsonld

@@ -105,6 +105,52 @@
      "@value" : "http://0.0.0.0:3336/ark:/72163/1/0001/H6gBWUuJSuuO=CilHV8kQwk/bXMwnrHvQH2DMjOFrGmNzgz.20180528T155203897Z"
    }
  },
+  "anything:hasGeometry" : {


I assume these values were introduced in #1514 but since the e2e tests were not run the difference in the test data was not detected.

benjamingeer · 2019-11-20T16:48:30Z

I assume these values were introduced in #1514 but since the e2e tests were not run the difference in the test data was not detected.

Actually, what happened is that at some point we added ARK URLs and UUIDs to values. After that, some hard-coded data that was supposed to fail validation (e.g. it had a boolean property with a string object, to check whether InstanceChecker would notice) started to fail validation because the hard-coded values in the test didn’t contain ARK URLs or UUIDs. So I had to add ARK UURLs and UUIDs to those values, to make them fail validation for the right reasons.

… Docker.

… into fix/1525-e2e-tests

benjamingeer · 2019-11-22T07:16:39Z

@subotic I don't understand what's happening. It does:

Setting up npm (3.5.2-0ubuntu4) ...

But then it says:

java.io.IOException: Cannot run program "npm" (in directory "/tmp/clientapi18252897938348417182/src"): error=2, No such file or directory

There is also this strange error, as if GraphDB sent a header saying that its response would be in GZIP format but the client couldn't unpack the file:

java.util.zip.ZipException: Not in GZIP format
2679
	at java.base/java.util.zip.GZIPInputStream.readHeader(GZIPInputStream.java:166)
2680
	at java.base/java.util.zip.GZIPInputStream.<init>(GZIPInputStream.java:80)
2681
	at java.base/java.util.zip.GZIPInputStream.<init>(GZIPInputStream.java:92)
2682
	at org.apache.http.client.entity.GZIPInputStreamFactory.create(GZIPInputStreamFactory.java:61)
2683
	at org.apache.http.client.entity.LazyDecompressingInputStream.initWrapper(LazyDecompressingInputStream.java:51)
2684
	at org.apache.http.client.entity.LazyDecompressingInputStream.read(LazyDecompressingInputStream.java:69)
2685
	at java.base/sun.nio.cs.StreamDecoder.readBytes(StreamDecoder.java:284)
2686
	at java.base/sun.nio.cs.StreamDecoder.implRead(StreamDecoder.java:326)
2687
	at java.base/sun.nio.cs.StreamDecoder.read(StreamDecoder.java:178)
2688
	at java.base/java.io.InputStreamReader.read(InputStreamReader.java:185)
2689
	at java.base/java.io.Reader.read(Reader.java:144)
2690
	at org.apache.http.util.EntityUtils.toString(EntityUtils.java:227)
2691
	at org.apache.http.util.EntityUtils.toString(EntityUtils.java:308)
2692
	at org.knora.webapi.store.triplestore.http.HttpTriplestoreConnector.$anonfun$getSparqlHttpResponse$1(HttpTriplestoreConnector.scala:662)
2693
	at scala.util.Try$.apply(Try.scala:213)
2694
	at org.knora.webapi.store.triplestore.http.HttpTriplestoreConnector.getSparqlHttpResponse(HttpTriplestoreConnector.scala:652)

benjamingeer · 2019-11-22T08:04:42Z

When I run all the tests outside Docker, they all pass.

benjamingeer · 2019-11-22T08:39:41Z

When I run the tests locally using make e2e-tests, is there a way to stop them? I tried Control-C, but it didn't have any effect, the tests kept running. I looked in the Docker Desktop menu but didn't find anything for stopping containers. I tried installing Kitematic, but it doesn't show any local containers either. I ended up finding the sbt process ID and using kill -9.

subotic · 2019-11-22T08:45:21Z

When I run all the tests outside Docker, they all pass.

Then npm is missing inside the Docker container. I will add it to the image.

When I run the tests using make e2e, is there a way to stop them?

No, the only way would be to kill the created api container from terminal:

$ docker container ls
$ docker container rm <container_id> // you could try 'api' as the container_id

subotic · 2019-11-22T09:13:10Z

I've updated the Docker image and restarted the tests. Let's see if this all that is needed.

benjamingeer · 2019-11-22T09:15:09Z

I've updated the Docker image

So do we still need this in main.yml?

      - name: install requirements
        run: sudo apt-get install nodejs npm

subotic · 2019-11-22T09:34:22Z

I've updated the Docker image

So do we still need this in main.yml?
      - name: install requirements
        run: sudo apt-get install nodejs npm

I don't think so.

benjamingeer · 2019-11-22T11:17:59Z

OMG the tests passed!

benjamingeer · 2019-11-22T12:17:42Z

Now it's failing because of this:

Triplestore responded with HTTP code 500:
Query evaluation error:
Insufficient free Heap Memory 240Mb for group by and distinct, threshold:250Mb, reached 0Mb (HTTP status 500)

subotic · 2019-11-22T13:29:39Z

Now it's failing because of this:

Triplestore responded with HTTP code 500:
Query evaluation error:
Insufficient free Heap Memory 240Mb for group by and distinct, threshold:250Mb, reached 0Mb (HTTP status 500)

Which test changed after the merge? GraphDB doesn't have enough memory.

benjamingeer · 2019-11-22T13:43:53Z

Which test changed after the merge? GraphDB doesn't have enough memory.

No tests changed, it was the merge of #1527. Can we give GraphDB more memory?

benjamingeer · 2019-11-25T15:30:22Z

@subotic Does this mean we can't use GitHub CI?

subotic · 2019-11-26T05:30:46Z

Which test changed after the merge? GraphDB doesn't have enough memory.

No tests changed, it was the merge of #1527. Can we give GraphDB more memory?

I don‘t think so.

Does this mean we can't use GitHub CI?

This means that we need to find a way how it can work with Github CI. Unfortunately, there is no alternative. After doing some calculations, running it on our own hardware is not feasible cost wise.

We could try and isolate the high memory tests with a HighMemory test tag and run them separately?

benjamingeer · 2019-11-26T12:25:18Z

OK the tests that use a lot of memory are the ones that create large texts with lots of standoff. I think we don't really need to run these in CI anyway, so I set them to ignore. Otherwise everything seems to work. Can we merge this?

subotic

Thanks, LGTM :-)

fix(build): Fix E2E tests.

a4b9378

benjamingeer added build labels Nov 20, 2019

benjamingeer added this to the 2019-11 milestone Nov 20, 2019

benjamingeer requested review from subotic and tobiasschweizer November 20, 2019 15:56

benjamingeer self-assigned this Nov 20, 2019

benjamingeer mentioned this pull request Nov 20, 2019

Ben's PR history #571

Open

subotic reviewed Nov 20, 2019

View reviewed changes

tobiasschweizer reviewed Nov 20, 2019

View reviewed changes

Benjamin Geer and others added 8 commits November 21, 2019 14:32

test: Fix more E2E tests.

27534dd

test: Make sure InstanceChecker tests fail for the right reasons.

31c5de3

Merge branch 'develop' into fix/1525-e2e-tests

e444f08

test: Change JSON-LD test to use the correct Sipi URL when running in…

046b6aa

… Docker.

test: Increase GraphDB timeout.

1b2411f

test: Fix fixes.

d32b428

build: fix Makefile

8f25048

Merge branch 'fix/1525-e2e-tests' of github.com:dasch-swiss/knora-api…

5212159

… into fix/1525-e2e-tests

benjamingeer assigned subotic Nov 21, 2019

subotic added 2 commits November 22, 2019 10:52

build(ci): optimize cache

740af56

build(ci): remove requirements

339012a

Merge branch 'develop' into fix/1525-e2e-tests

2f8cd15

Benjamin Geer added 5 commits November 26, 2019 08:45

test: Ignore tests with large texts to save memory on GitHub CI.

d7c78d7

test: Fix fix.

2a5d194

test: Fix other fix.

959f0b1

test: Increase timeout.

a6c0103

test: Fix fix that I thought I had already fixed.

0af229a

subotic approved these changes Nov 26, 2019

View reviewed changes

benjamingeer merged commit b3d1638 into develop Nov 26, 2019

benjamingeer deleted the fix/1525-e2e-tests branch November 26, 2019 12:41

benjamingeer mentioned this pull request Dec 5, 2019

Incorrect property names in generated admin API code #1545

Closed

tobiasschweizer mentioned this pull request Dec 5, 2019

fix(clientapi): Fix property names. #1546

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(build): Fix E2E tests #1526

fix(build): Fix E2E tests #1526

benjamingeer commented Nov 20, 2019 •

edited

Loading

subotic Nov 20, 2019

tobiasschweizer Nov 20, 2019

benjamingeer commented Nov 20, 2019

benjamingeer commented Nov 22, 2019

benjamingeer commented Nov 22, 2019

benjamingeer commented Nov 22, 2019 •

edited

Loading

subotic commented Nov 22, 2019

subotic commented Nov 22, 2019

benjamingeer commented Nov 22, 2019

subotic commented Nov 22, 2019

benjamingeer commented Nov 22, 2019

benjamingeer commented Nov 22, 2019

subotic commented Nov 22, 2019

benjamingeer commented Nov 22, 2019

benjamingeer commented Nov 25, 2019

subotic commented Nov 26, 2019

benjamingeer commented Nov 26, 2019

subotic left a comment



		protected def singleAwaitingRequest(request: HttpRequest, duration: Duration = 5999.milliseconds): HttpResponse = {
		protected def singleAwaitingRequest(request: HttpRequest, duration: Duration = 7999.milliseconds): HttpResponse = {

fix(build): Fix E2E tests #1526

fix(build): Fix E2E tests #1526

Conversation

benjamingeer commented Nov 20, 2019 • edited Loading

subotic Nov 20, 2019

Choose a reason for hiding this comment

tobiasschweizer Nov 20, 2019

Choose a reason for hiding this comment

benjamingeer commented Nov 20, 2019

benjamingeer commented Nov 22, 2019

benjamingeer commented Nov 22, 2019

benjamingeer commented Nov 22, 2019 • edited Loading

subotic commented Nov 22, 2019

subotic commented Nov 22, 2019

benjamingeer commented Nov 22, 2019

subotic commented Nov 22, 2019

benjamingeer commented Nov 22, 2019

benjamingeer commented Nov 22, 2019

subotic commented Nov 22, 2019

benjamingeer commented Nov 22, 2019

benjamingeer commented Nov 25, 2019

subotic commented Nov 26, 2019

benjamingeer commented Nov 26, 2019

subotic left a comment

Choose a reason for hiding this comment

benjamingeer commented Nov 20, 2019 •

edited

Loading

benjamingeer commented Nov 22, 2019 •

edited

Loading