-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(clientapi): Fix property names. #1546
Conversation
Why does the IIIF Url look like this in the test data: |
I think this was introduced in #1526 as well. |
I can confirm that the problem with the generated admin code is fixed. |
Because Sipi's hostname and port depend on whether Knora is running in a Docker container or not. The Knora E2E tests now replace |
I am using https://github.com/dasch-swiss/knora-api/blob/064ca4a4381c79acbd9b33e3ee847e46ecc6d443/webapi/src/test/resources/test-data/resourcesR2RV2/NarrenschiffFirstPage.jsonld in knora-api-lib-js. Would it be better if everything was generated instead of copied from the git repo? |
It's no problem to generate it, just tell me what you need. |
OK I'll do it as part of this: dasch-swiss/dsp-js-lib#115 (comment) |
It will be in a separate PR. Can I merge this one for now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, good to go. Thanks!
Fixes #1545.