Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(clientapi): Fix property names. #1546

Merged
merged 1 commit into from
Dec 6, 2019

Conversation

benjamingeer
Copy link

Fixes #1545.

@benjamingeer benjamingeer added the clientapi frontend: Salsah, DSP-APP, BEOL, MLS, etc. label Dec 5, 2019
@benjamingeer benjamingeer added this to the 2019-12 milestone Dec 5, 2019
@benjamingeer benjamingeer self-assigned this Dec 5, 2019
@tobiasschweizer
Copy link
Contributor

@tobiasschweizer
Copy link
Contributor

I think this was introduced in #1526 as well.

@tobiasschweizer
Copy link
Contributor

I can confirm that the problem with the generated admin code is fixed.

@benjamingeer
Copy link
Author

Why does the IIIF Url look like this in the test data

Because Sipi's hostname and port depend on whether Knora is running in a Docker container or not. The Knora E2E tests now replace IIIF_BASE_URL with the actual host and port at runtime.

@tobiasschweizer
Copy link
Contributor

I am using https://github.com/dasch-swiss/knora-api/blob/064ca4a4381c79acbd9b33e3ee847e46ecc6d443/webapi/src/test/resources/test-data/resourcesR2RV2/NarrenschiffFirstPage.jsonld in knora-api-lib-js. Would it be better if everything was generated instead of copied from the git repo?

@benjamingeer
Copy link
Author

Would it be better if everything was generated instead of copied from the git repo?

It's no problem to generate it, just tell me what you need.

@tobiasschweizer
Copy link
Contributor

@benjamingeer
Copy link
Author

OK I'll do it as part of this: dasch-swiss/dsp-js-lib#115 (comment)

@benjamingeer
Copy link
Author

It will be in a separate PR. Can I merge this one for now?

Copy link
Contributor

@tobiasschweizer tobiasschweizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, good to go. Thanks!

@benjamingeer benjamingeer merged commit b3eb1bd into develop Dec 6, 2019
@benjamingeer benjamingeer deleted the fix/1545-description-property branch December 6, 2019 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clientapi frontend: Salsah, DSP-APP, BEOL, MLS, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect property names in generated admin API code
2 participants