fix (webapi): CORS problems #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobiasschweizer
changed the title
|
@github: Github has also some bugs. The last four changes where made by me (@subotic) and not @tobiasschweizer |
|
This should work now. @tobiasschweizer could you please test it again with Salsah? |
|
I have a look at it right now. |
tobiasschweizer
commented
Nov 7, 2016
| implicit def corsRejection = corsRejectionHandler | ||
|
|
||
| /** | ||
| * Bring the Knora exception handler into scope, which is responsible for converting our exceptions to HttpResponses |
|
Nice job! Now I can delete resources and I get proper error messages on failed attempts to manipulate values. |
|
Thanks :-) Can I merge? |
|
Yes, I think so. There is a small typo I found in the documentation you could fix before merging. |
The typo is in code that was deleted ;-) |
|
Still I want to fix it! joking, sorry, my fault |
SepidehAlassi
added a commit
that referenced
this pull request
Dec 13, 2016
* develop: Improve configuration for more concurrent requests (#338) Upgrade to Scala 2.12 (#343) Fix various inconsistencies in knora-base.ttl and docs. (#330) Fix language switching and login/logout in SALSAH (#331) Graph data API operation (#267) Allow connections over HTTPS (#332) Update README.md Add link to GraphDB. fix (salsah): Add missing JavaScript “var”. fix (webapi): Fix RouteUtilV1 so it returns HTML instead of JSON when requested (#326) Ontology and documentation fixes. (#325) fix (salsah): Create multiple links in a resource, and other bug fixes (#315) feature (webapi): Make TransformData fix “test” labels on regions. (#311) Fixes for subclasses and subproperties (#303) Add script to update docs on knora.org (#300) docs: Make trivial change for testing purposes. fix (webapi): CORS problems (#307) Use inference to optimise searches on GraphDB (#301)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Access-Control-Allow-Originis missing in response header and thus the browser blocks the answer (in responses with status code other than 200).