Fix various inconsistencies in knora-base.ttl and docs. #330

benjamingeer · 2016-11-21T17:56:17Z

Fixes inconsistencies in knora-base.ttl:

Add datatype properties knora-base:name, knora-base:givenName, and knora-base:familyName, as subproperties of the corresponding foaf properties and of knora-base:objectCannotBeMarkedAsDeleted, and use the knora-base properties instead of the foaf ones, so consistency rules can check them properly.
Change the type of knora-base:valueHas to rdf:Property, so its subproperties can be either object properties or datatype properties.
Make valueHasListNode an object property.
Remove incorrect cardinalities for hasComment on value classes.
Fix cardinalities on DocumentRepresentation and TextRepresentation.
Remove unused properties currentproject, filename, and protocol.
Don't use foaf:birthday, whose object should be a literal.
Don't use foaf:member, because it means the opposite of what was intended.
Improve comments and labels.
Use the term Julian Day Number instead of Julian Day Count (JDC or JDN? #327).

Test data and tests are fixed accordingly. There are also some corrections and clarifications in knora-base.rst.

Closes #327.
Closes #328.

… and docs (#328).

…ount (#327).

…n foaf:Person, because SystemUser isn’t a person (#328).

tobiasschweizer · 2016-11-28T14:33:23Z

knora-ontologies/knora-base.ttl

@@ -724,9 +735,7 @@

             :subjectClassConstraint :User ;

-             :objectClassConstraint :knoraProject ;
-
-             rdfs:subPropertyOf foaf:member .


I assume that we do not relate �isInGroup to foaf anymore.

Yes, as the pull request description says: "Don't use foaf:member, because it means the opposite of what was intended."

tobiasschweizer · 2016-11-28T15:00:16Z

knora-ontologies/knora-base.ttl

@@ -1473,7 +1459,7 @@

 ###  http://www.knora.org/ontology/knora-base#valueHas

-:valueHas rdf:type owl:DatatypeProperty ;
+:valueHas rdf:type rdf:Property ;


Why would a subproperty of valueHas be an object property? Wouldn't it rather be a subproperty of hasLinkTo then?

For example, valueHasListNode has to be an object property, because its object is aListNode, not a literal. It can't be a subproperty of hasLinkTo, because both the subject and object of hasLinkTo must be instances of Resource.

tobiasschweizer · 2016-11-28T15:01:24Z

knora-ontologies/knora-base.ttl

@@ -1637,7 +1623,7 @@

 ###  http://www.knora.org/ontology/knora-base#valueHasListNode

-:valueHasListNode rdf:type owl:DatatypeProperty ;
+:valueHasListNode rdf:type owl:ObjectProperty ;


Is this change the answer to my question above?

tobiasschweizer · 2016-11-28T15:05:52Z

knora-ontologies/knora-base.ttl

@@ -2730,11 +2700,7 @@

 :TextFileValue rdf:type owl:Class ;


Are we going to store a document in the triplestore itself or are we going to store a file path?

I think in case of an XML file or any other simple plain text format we could store it in the triplestore, but not other non trivial formats.

It would make sense to store it in the triplestore if we could search its contents using full-text search. I think Lucene can be configured to handle XML syntax, but we'd have to look into this. Otherwise, I think it makes more sense to store it in a file.

tobiasschweizer · 2016-11-28T15:09:44Z

webapi/_test_data/responders.v1.SipiResponderV1Spec/incunabula-data.ttl

@@ -9,40 +9,110 @@
 @prefix salsah-gui: <http://www.knora.org/ontology/salsah-gui#> .


I do not understand what you did in this file.

Or did you transform it using Transform data to change jdc to jdn?

tobiasschweizer · 2016-11-28T15:14:34Z

webapi/src/main/scala/org/knora/webapi/util/TransformData.scala

@@ -254,8 +260,6 @@ object TransformData extends App {

    /**
      * Looks for regions that have the label "test" and changes their label to the value of their `knora-base:hasComment`.
-      *


Why did you remove the documentation of the required param? Because it is already documented in the abstract super class?

Yes, but I'll put it back.

* develop: Improve configuration for more concurrent requests (#338) Upgrade to Scala 2.12 (#343) Fix various inconsistencies in knora-base.ttl and docs. (#330) Fix language switching and login/logout in SALSAH (#331) Graph data API operation (#267) Allow connections over HTTPS (#332) Update README.md Add link to GraphDB. fix (salsah): Add missing JavaScript “var”. fix (webapi): Fix RouteUtilV1 so it returns HTML instead of JSON when requested (#326) Ontology and documentation fixes. (#325) fix (salsah): Create multiple links in a resource, and other bug fixes (#315) feature (webapi): Make TransformData fix “test” labels on regions. (#311) Fixes for subclasses and subproperties (#303) Add script to update docs on knora.org (#300) docs: Make trivial change for testing purposes. fix (webapi): CORS problems (#307) Use inference to optimise searches on GraphDB (#301)

fix (knora-ontologies): Fix various inconsistencies in knora-base.ttl…

05f675a

… and docs (#328).

kilchenmann added the in-progress label Nov 21, 2016

benjamingeer added the bug something isn't working label Nov 21, 2016

benjamingeer added this to the Beta Release milestone Nov 21, 2016

benjamingeer assigned tobiasschweizer Nov 21, 2016

benjamingeer added the ready-for-review label Nov 21, 2016

benjamingeer mentioned this pull request Nov 21, 2016

Knora Base Ontology and documentation #328

Closed

Benjamin Geer added 2 commits November 22, 2016 13:39

fix (knora-ontologies): Use Julian Day Number instead of Julian Day C…

794acc8

…ount (#327).

fix (knora-ontologies): Make User a subclass of foaf:Agent rather tha…

ed70acc

…n foaf:Person, because SystemUser isn’t a person (#328).

tobiasschweizer reviewed Nov 28, 2016

View reviewed changes

style (webapi): Add comments.

1b295c4

benjamingeer merged commit 3d7176b into develop Nov 28, 2016

benjamingeer deleted the wip/ontology-fixes branch November 28, 2016 16:32

kilchenmann removed in-progress labels Nov 28, 2016

benjamingeer mentioned this pull request Jul 5, 2019

Ben's PR history #571

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix various inconsistencies in knora-base.ttl and docs. #330

Fix various inconsistencies in knora-base.ttl and docs. #330

benjamingeer commented Nov 21, 2016 •

edited

Loading

tobiasschweizer Nov 28, 2016 •

edited

Loading

benjamingeer Nov 28, 2016

tobiasschweizer Nov 28, 2016

benjamingeer Nov 28, 2016

tobiasschweizer Nov 28, 2016

benjamingeer Nov 28, 2016

tobiasschweizer Nov 28, 2016

benjamingeer Nov 28, 2016

tobiasschweizer Nov 28, 2016

tobiasschweizer Nov 28, 2016

benjamingeer Nov 28, 2016

tobiasschweizer Nov 28, 2016

benjamingeer Nov 28, 2016

		@@ -9,40 +9,110 @@
		@prefix salsah-gui: <http://www.knora.org/ontology/salsah-gui#> .

Fix various inconsistencies in knora-base.ttl and docs. #330

Fix various inconsistencies in knora-base.ttl and docs. #330

Conversation

benjamingeer commented Nov 21, 2016 • edited Loading

tobiasschweizer Nov 28, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

benjamingeer commented Nov 21, 2016 •

edited

Loading

tobiasschweizer Nov 28, 2016 •

edited

Loading