Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add method to create a resource #115

Merged
merged 28 commits into from
Dec 12, 2019
Merged

add method to create a resource #115

merged 28 commits into from
Dec 12, 2019

Conversation

tobiasschweizer
Copy link
Contributor

@tobiasschweizer tobiasschweizer commented Dec 3, 2019

Add method to create a resource.

@tobiasschweizer tobiasschweizer self-assigned this Dec 3, 2019
@tobiasschweizer
Copy link
Contributor Author

@benjamingeer I added support for resource creation, update of a resource's metadata, and deletion. Do you want to generate JSON-LD test data as you did for the values?

@tobiasschweizer
Copy link
Contributor Author

@benjamingeer I will adapt the specs to the test data, that should be easy.

@benjamingeer
Copy link
Contributor

OK, will do.

@tobiasschweizer
Copy link
Contributor Author

@benjamingeer I had to change "100000000000000.000000000000001" to 1.5

@benjamingeer
Copy link
Contributor

I had to change "100000000000000.000000000000001" to 1.5

https://www.npmjs.com/package/js-big-decimal

@tobiasschweizer
Copy link
Contributor Author

Yes, I saw his too (dasch-swiss/dsp-api#1549 (comment)). Yet another dependency ...

@benjamingeer
Copy link
Contributor

Yes, I saw his too (dasch-swiss/dsp-api#1549 (comment)). Yet another dependency ...

Or you can just use string. But we can't lose precision, that would be equivalent to losing data.

@tobiasschweizer
Copy link
Contributor Author

Or you can just use string. But we can't lose precision, that would be equivalent to losing data.

I will look at this and try to figure something out. I remember that we had this problem in Scala too before using BigDecimal.

@tobiasschweizer
Copy link
Contributor Author

@benjamingeer I think I will create a separate issue to deal with precisions

Copy link
Contributor

@benjamingeer benjamingeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me!

Let's start thinking about how to automatically generate some of this.

@tobiasschweizer tobiasschweizer merged commit 56171d3 into master Dec 12, 2019
@tobiasschweizer tobiasschweizer deleted the wip/create-resource branch December 12, 2019 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants