fix(ingest): handle endpoints without 200 response in openapi (#4332)

datahub-project · Mar 15, 2022 · af5c4ee · af5c4ee
1 parent 50ef658
commit af5c4ee
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/metadata-ingestion/src/datahub/ingestion/source/openapi_parser.py b/metadata-ingestion/src/datahub/ingestion/source/openapi_parser.py
@@ -120,10 +120,14 @@ def get_endpoints(sw_dict: dict) -> dict:  # noqa: C901
         # will track only the "get" methods, which are the ones that give us data
         if "get" in p_o.keys():
 
-            try:
+            if "200" in p_o["get"]["responses"].keys():
                 base_res = p_o["get"]["responses"]["200"]
-            except KeyError:  # if you read a plain yml file the 200 will be an integer
+            elif 200 in p_o["get"]["responses"].keys():
+                # if you read a plain yml file the 200 will be an integer
                 base_res = p_o["get"]["responses"][200]
+            else:
+                # the endpoint does not have a 200 response
+                continue
 
             if "description" in p_o["get"].keys():
                 desc = p_o["get"]["description"]

diff --git a/metadata-ingestion/tests/unit/test_openapi.py b/metadata-ingestion/tests/unit/test_openapi.py
@@ -261,6 +261,13 @@ class TestGetEndpoints(unittest.TestCase):
                         }
                     ]
                    }
+  /redirect:
+    get:
+      operationId: redirectSomewhere
+      summary: Redirect to a different endpoint
+      responses:
+        '302':
+          description: 302 response
   /v2:
     get:
       operationId: getVersionDetailsv2