Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest): handle endpoints without 200 response in openapi #4332

Merged
merged 1 commit into from
Mar 15, 2022
Merged

fix(ingest): handle endpoints without 200 response in openapi #4332

merged 1 commit into from
Mar 15, 2022

Conversation

JorgenEvens
Copy link
Contributor

This PR prevents a crash on openapi documents that have GET endpoints without a 200 response. For example endpoints that are intended for redirects and only contain 302 responses.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

RyanHolstien
RyanHolstien approved these changes Mar 7, 2022
View reviewed changes
Copy link
Collaborator

@RyanHolstien RyanHolstien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link

github-actions bot commented Mar 8, 2022

Unit Test Results (build & test)

  76 files  +  1    76 suites  +1   15m 9s ⏱️ - 3m 9s
629 tests +82  566 ✔️ +72  62 💤 +10  1 ❌ ±0 

For more details on these failures, see this check.

Results for commit df4b9b1. ± Comparison against base commit 7efc88e.

@github-actions
Copy link

github-actions bot commented Mar 8, 2022

Unit Test Results (metadata ingestion)

       5 files         5 suites   45m 15s ⏱️
   347 tests    346 ✔️   0 💤 1 ❌
1 579 runs  1 540 ✔️ 38 💤 1 ❌

For more details on these failures, see this check.

Results for commit df4b9b1.

rslanka
rslanka approved these changes Mar 14, 2022
View reviewed changes
Copy link
Contributor

@rslanka rslanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

shirshanka
shirshanka approved these changes Mar 15, 2022
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit af5c4ee into datahub-project:master Mar 15, 2022
@JorgenEvens JorgenEvens deleted the fix/ingest-openapi-responses branch March 15, 2022 09:25
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
@JorgenEvens @maggiehays
fix(ingest): handle endpoints without 200 response in openapi (datahu…
1ab8c20 
…b-project#4332)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanHolstien RyanHolstien RyanHolstien approved these changes

@rslanka rslanka rslanka approved these changes

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JorgenEvens @shirshanka @rslanka @RyanHolstien