Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingest): Restricting pytest docker version to <0.12 #4639

Merged
merged 1 commit into from
Apr 11, 2022

Conversation

treff7es
Copy link
Contributor

Pytest docker introduced a breaking change by adding an additional non-default parameter to method calls. (avast/pytest-docker@875aee3#diff-2b5692d86e8853b3342a3c71d5447bb217a829e3302e857ceb37ff831422279dL162)

In this fix I'm setting max/min version for this package

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@treff7es treff7es changed the title fix(ingest): Restricting pytest docker version fix(ingest): Restricting pytest docker version to <0.12 Apr 11, 2022
Copy link
Contributor

@rslanka rslanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link

Unit Test Results (build & test)

  96 files    96 suites   18m 48s ⏱️
689 tests 630 ✔️ 59 💤 0

Results for commit 122bb77.

@github-actions
Copy link

Unit Test Results (metadata ingestion)

       5 files         5 suites   1h 4m 25s ⏱️
   396 tests    396 ✔️   0 💤 0
1 911 runs  1 867 ✔️ 44 💤 0

Results for commit 122bb77.

@treff7es treff7es merged commit e2a617f into datahub-project:master Apr 11, 2022
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants