build(ingest): remove markupsafe dep and bump pytest-docker #6201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like the aws-sam-cli package has updated their versions appropriately, which means that we are clear to remove this. This will eventually help improve compat with newer versions of Airflow.
github-actions
bot
added
the
ingestion
Unit Test Results (metadata ingestion) 8 files ±0 8 suites ±0 54m 55s ⏱️ - 5m 11s For more details on these errors, see this check. Results for commit c45b182. ± Comparison against base commit 521e61d. ♻️ This comment has been updated with latest results. |
5 tasks
hsheth2
changed the title
cccs-tom
pushed a commit
to CybercentreCanada/datahub
that referenced
this pull request
Nov 18, 2022
cccs-tom
pushed a commit
to CybercentreCanada/datahub
that referenced
this pull request
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will help improve compat with newer versions of Airflow.
markupsafe: It looks like the aws-sam-cli package has updated their versions appropriately, which means that we are clear to remove this. Note: I'm not sure where we're actually depending on aws-sam-cli, since it never gets installed for me locally despite all sources being enabled.
pytest-docker: This was a simple upgrade - moving to 1.x introduced some extra non-defaulted parameters, so we just needed to fill those out.
Previous PRs:
Checklist