Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lineage): fix missed casing in lineage registry #6078

Merged
merged 6 commits into from
Sep 30, 2022
Merged

fix(lineage): fix missed casing in lineage registry #6078

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7d9fa88
fix backwards case sensitive lineage
gabe-lyons Sep 28, 2022
7f9a9e5
update tests
gabe-lyons Sep 28, 2022
b86eb2c
make EdgeInfo equals and hashcode case resilient
gabe-lyons Sep 29, 2022
b88cfa4
Merge branch 'master' into gabe--fixBackwardsCaseSensitiveLineage
gabe-lyons Sep 29, 2022
db2d745
updating lint
gabe-lyons Sep 29, 2022
4cd20f4
Merge branch 'master' into gabe--fixBackwardsCaseSensitiveLineage
jjoyce0510 Sep 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions entity-registry/src/main/java/com/linkedin/metadata/models/registry/LineageRegistry.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,14 +57,14 @@ private Map<String, LineageSpec> buildLineageSpecs(EntityRegistry entityRegistry
for (LineageEdge edge : lineageEdges) {
if (edge.isUpstream()) {
upstreamPerEntity.computeIfAbsent(edge.sourceEntity.toLowerCase(), (k) -> new HashSet<>())
.add(new EdgeInfo(edge.type, RelationshipDirection.OUTGOING, edge.destEntity));
.add(new EdgeInfo(edge.type, RelationshipDirection.OUTGOING, edge.destEntity.toLowerCase()));
downstreamPerEntity.computeIfAbsent(edge.destEntity.toLowerCase(), (k) -> new HashSet<>())
.add(new EdgeInfo(edge.type, RelationshipDirection.INCOMING, edge.sourceEntity));
.add(new EdgeInfo(edge.type, RelationshipDirection.INCOMING, edge.sourceEntity.toLowerCase()));
} else {
downstreamPerEntity.computeIfAbsent(edge.sourceEntity.toLowerCase(), (k) -> new HashSet<>())
.add(new EdgeInfo(edge.type, RelationshipDirection.OUTGOING, edge.destEntity));
.add(new EdgeInfo(edge.type, RelationshipDirection.OUTGOING, edge.destEntity.toLowerCase()));
upstreamPerEntity.computeIfAbsent(edge.destEntity.toLowerCase(), (k) -> new HashSet<>())
.add(new EdgeInfo(edge.type, RelationshipDirection.INCOMING, edge.sourceEntity));
.add(new EdgeInfo(edge.type, RelationshipDirection.INCOMING, edge.sourceEntity.toLowerCase()));
}
}

Expand Down
4 changes: 2 additions & 2 deletions entity-registry/src/test/java/com/linkedin/metadata/models/registry/LineageRegistryTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,12 +53,12 @@ public void testRegistry() {
assertTrue(lineageSpec.getUpstreamEdges()
.contains(new LineageRegistry.EdgeInfo("DownstreamOf", RelationshipDirection.OUTGOING, "dataset")));
assertTrue(lineageSpec.getUpstreamEdges()
.contains(new LineageRegistry.EdgeInfo("Produces", RelationshipDirection.INCOMING, "dataJob")));
.contains(new LineageRegistry.EdgeInfo("Produces", RelationshipDirection.INCOMING, "datajob")));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waitttt are the edges really having lower case?

assertEquals(lineageSpec.getDownstreamEdges().size(), 2);
assertTrue(lineageSpec.getDownstreamEdges()
.contains(new LineageRegistry.EdgeInfo("DownstreamOf", RelationshipDirection.INCOMING, "dataset")));
assertTrue(lineageSpec.getDownstreamEdges()
.contains(new LineageRegistry.EdgeInfo("Consumes", RelationshipDirection.INCOMING, "dataJob")));
.contains(new LineageRegistry.EdgeInfo("Consumes", RelationshipDirection.INCOMING, "datajob")));
}

private RelationshipFieldSpec buildSpec(String relationshipType, List<String> destinationEntityTypes,
Expand Down