Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest): only restrict GE version for hive #6170

Merged
merged 2 commits into from
Oct 15, 2022
Merged

fix(ingest): only restrict GE version for hive #6170

merged 2 commits into from
Oct 15, 2022

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Oct 11, 2022 •
edited
Loading

Follow-up on #5980.

Related to great-expectations/great_expectations#6146.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Oct 11, 2022
@github-actions
Copy link

github-actions bot commented Oct 11, 2022 •
edited
Loading

Unit Test Results (metadata ingestion)

       8 files  ±  0         8 suites  ±0   58m 25s ⏱️ -9s
   737 tests +  6     735 ✔️ +  6  2 💤 ±0  0 ❌ ±0 
1 476 runs  +12  1 472 ✔️ +12  4 💤 ±0  0 ❌ ±0 

Results for commit 82ebb3d. ± Comparison against base commit 95d1e01.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 11, 2022 •
edited
Loading

Unit Test Results (build & test)

0 tests   - 597   0 ✔️  - 593   0s ⏱️ - 11m 59s
0 suites  - 147   0 💤  -     4 
0 files    - 147   0 ❌ ±    0 

Results for commit 82ebb3d. ± Comparison against base commit 95d1e01.

♻️ This comment has been updated with latest results.

shirshanka
shirshanka approved these changes Oct 15, 2022
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit fbe4b72 into datahub-project:master Oct 15, 2022
cccs-tom pushed a commit to CybercentreCanada/datahub that referenced this pull request Nov 18, 2022
@hsheth2 @cccs-tom
fix(ingest): only restrict GE version for hive (datahub-project#6170)
d18c981
cccs-tom pushed a commit to CybercentreCanada/datahub that referenced this pull request Nov 18, 2022
@hsheth2 @cccs-tom
fix(ingest): only restrict GE version for hive (datahub-project#6170)
ba1a3fb
@hsheth2 hsheth2 deleted the hive-ge-version branch February 14, 2024 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mayurinehate mayurinehate mayurinehate approved these changes

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hsheth2 @shirshanka @mayurinehate