Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingest): only restrict GE version for hive #6170

Merged
merged 2 commits into from
Oct 15, 2022
Merged

fix(ingest): only restrict GE version for hive #6170

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
03e03e0
fix(ingest): only restrict GE version for hive
hsheth2 Oct 11, 2022
82ebb3d
cleanup ge version denylist
hsheth2 Oct 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion metadata-ingestion/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ def get_long_description():
# Required for all SQL sources.
"sqlalchemy==1.3.24",
# Required for SQL profiling.
"great-expectations>=0.15.12, <0.15.23",
"great-expectations>=0.15.12",
# GE added handling for higher version of jinja2
# https://github.com/great-expectations/great_expectations/pull/5382/files
# datahub does not depend on traitlets directly but great expectations does.
Expand Down Expand Up @@ -262,6 +262,9 @@ def get_long_description():
# - 0.6.12 adds support for Spark Thrift Server
"acryl-pyhive[hive]>=0.6.13",
"databricks-dbapi",
# Due to https://github.com/great-expectations/great_expectations/issues/6146,
# we need to restrict the version of great-expectations.
"great-expectations<0.15.23",
},
"iceberg": iceberg_common,
"kafka": {*kafka_common, *kafka_protobuf},
Expand Down