feat(build): refactor cypress tests, add some tests for invite users, domain creation #6259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anshbansal
changed the title
gabe-lyons
reviewed
Oct 24, 2022
smoke-test/tests/cypress/cypress/integration/glossary/glossary.js
Outdated
Show resolved
Hide resolved
gabe-lyons
reviewed
Oct 24, 2022
gabe-lyons
reviewed
Oct 24, 2022
gabe-lyons
reviewed
Oct 24, 2022
Comment on lines
+37
to
+39
| // Verify you can’t generate a reset password link for a non-native user (root, for example) | ||
| // Generate a reset password link for a native user | ||
| // Log out, then verify that using a bad reset token in the URL doesn’t allow you to reset password |
There was a problem hiding this comment.
lets move this comment to above the method its describing
There was a problem hiding this comment.
these are todos. I'll automate these this week.
gabe-lyons
reviewed
Oct 24, 2022
smoke-test/tests/cypress/cypress/integration/mutations/deprecations.js
Outdated
Show resolved
Hide resolved
gabe-lyons
reviewed
Oct 24, 2022
Comment on lines
+21
to
+24
| // add asset to domain | ||
| // Search filter by domain | ||
| // Remove entity from domain | ||
| // Delete a domain - ensure that the dangling reference is deleted on the asset |
There was a problem hiding this comment.
if these are to-do's lets mark them as todos?
There was a problem hiding this comment.
these are todos. I'll automate these this week.
gabe-lyons
reviewed
Oct 24, 2022
gabe-lyons
reviewed
Oct 24, 2022
cccs-tom
pushed a commit
to CybercentreCanada/datahub
that referenced
this pull request
Nov 18, 2022
cccs-tom
pushed a commit
to CybercentreCanada/datahub
that referenced
this pull request
Nov 18, 2022
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist