feat(ci): add smoke test for domain mutation #6641
Conversation
| cy.get(".ant-checkbox-input").first().click() | ||
| cy.get("#continueButton").click() | ||
| }) | ||
| cy.waitTextVisible("Added assets to Domain!") |
There was a problem hiding this comment.
let's get rid of this one. any of the popover messages, i think we should avoid putting in the tests. we often change the text, and are moving towards getting rid of these!
There was a problem hiding this comment.
Domain page does not get updated when assets are added to it. You have to refresh the page before the assets appear. If we refresh the page before assets are added the request might not complete. So this is currently the only way to do this test reliably until we change the domain page to actually refresh the UI when asset addition is complete
There was a problem hiding this comment.
@anshbansal as a temporary placeholder let's just add a wait then, e.g. 5 seconds
There was a problem hiding this comment.
Adding wait times will turn this into a flaky test. I had removed all the temp wait times to remove flakiness in these tests.
There was a problem hiding this comment.
No no the caching work has made it instant. Try on demo
There was a problem hiding this comment.
It's okay. This is fine for now.
smoke-test/tests/cypress/cypress/integration/mutations/domains.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
approving it without context, based on @jjoyce0510 's comment
Follow-up #6259 to add tests for domains
Checklist