Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(ingest): move prerequisite section before the ingestion recipe example #6341

Merged
merged 2 commits into from
Nov 15, 2022
Merged

docs(ingest): move prerequisite section before the ingestion recipe example #6341

merged 2 commits into from
Nov 15, 2022

Conversation

mayurinehate
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Nov 2, 2022
@github-actions
Copy link

github-actions bot commented Nov 2, 2022 •
edited
Loading

Unit Test Results (metadata ingestion)

       8 files  ±0         8 suites  ±0   59m 6s ⏱️ + 3m 12s
   758 tests ±0     755 ✔️ ±0  3 💤 ±0  0 ❌ ±0 
1 518 runs  ±0  1 511 ✔️ ±0  7 💤 ±0  0 ❌ ±0 

Results for commit 7733528. ± Comparison against base commit d87dcfa.

♻️ This comment has been updated with latest results.

@mayurinehate mayurinehate marked this pull request as ready for review November 3, 2022 12:16
@github-actions
Copy link

github-actions bot commented Nov 3, 2022 •
edited
Loading

Unit Test Results (build & test)

613 tests  ±0   609 ✔️ ±0   11m 47s ⏱️ +6s
151 suites ±0       4 💤 ±0 
151 files   ±0       0 ❌ ±0 

Results for commit 7733528. ± Comparison against base commit d87dcfa.

♻️ This comment has been updated with latest results.

@hsheth2 hsheth2 changed the title docs(ingest): move pre-requisite section before the ingestion recipe example docs(ingest): move prerequisite section before the ingestion recipe example Nov 15, 2022
@hsheth2 hsheth2 merged commit e78b037 into datahub-project:master Nov 15, 2022
@mayurinehate mayurinehate deleted the docs_prerequisites branch November 16, 2022 03:29
cccs-Dustin pushed a commit to CybercentreCanada/datahub that referenced this pull request Feb 1, 2023
@mayurinehate @cccs-Dustin
docs(ingest): move prerequisite section before the ingestion recipe e…
5eb7b7d 
…xample (datahub-project#6341)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

@shirshanka shirshanka Awaiting requested review from shirshanka

@treff7es treff7es Awaiting requested review from treff7es

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mayurinehate @hsheth2