Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(ingest): move prerequisite section before the ingestion recipe example #6341

Merged
merged 2 commits into from
Nov 15, 2022
Merged

docs(ingest): move prerequisite section before the ingestion recipe example #6341

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
272eee8
docs(ingest): move prerequisites before ingestion recipe
mayurinehate Nov 1, 2022
7733528
changes in powerbi and trino doc
mayurinehate Nov 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 .../docs/sources/bigquery/bigquery-legacy.md → ...s/sources/bigquery/bigquery-legacy_pre.md
View file
Open in desktop
File renamed without changes.
0 ...sources/bigquery/bigquery-usage-legacy.md → ...ces/bigquery/bigquery-usage-legacy_pre.md
View file
Open in desktop
File renamed without changes.
0 ...ata-ingestion/docs/sources/mysql/mysql.md → ...ingestion/docs/sources/mysql/mysql_pre.md
View file
Open in desktop
File renamed without changes.
0 .../sources/powerbi/powerbi-report-server.md → ...rces/powerbi/powerbi-report-server_pre.md
View file
Open in desktop
File renamed without changes.
0 ...ingestion/docs/sources/powerbi/powerbi.md → ...stion/docs/sources/powerbi/powerbi_pre.md
View file
Open in desktop
File renamed without changes.
0 ...a-ingestion/docs/sources/pulsar/pulsar.md → ...gestion/docs/sources/pulsar/pulsar_pre.md
View file
Open in desktop
File renamed without changes.
0 ...ion/docs/sources/salesforce/salesforce.md → ...docs/sources/salesforce/salesforce_pre.md
View file
Open in desktop
File renamed without changes.
0 ...ocs/sources/snowflake/snowflake-legacy.md → ...sources/snowflake/snowflake-legacy_pre.md
View file
Open in desktop
File renamed without changes.
0 ...ingestion/docs/sources/vertica/vertica.md → ...stion/docs/sources/vertica/vertica_pre.md
View file
Open in desktop
File renamed without changes.
6 changes: 3 additions & 3 deletions metadata-ingestion/src/datahub/ingestion/source/ge_profiling_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,17 +89,17 @@ class GEProfilingConfig(ConfigModel):

profile_if_updated_since_days: Optional[pydantic.PositiveFloat] = Field(
default=1,
description="Profile table only if it has been updated since these many number of days. If set to `null`, no constraint of last modified time for tables to profile. Supported only in `snowflake`, `snowflake-beta` and `BigQuery`.",
description="Profile table only if it has been updated since these many number of days. If set to `null`, no constraint of last modified time for tables to profile. Supported only in `snowflake` and `BigQuery`.",
)

profile_table_size_limit: Optional[int] = Field(
default=1,
description="Profile tables only if their size is less then specified GBs. If set to `null`, no limit on the size of tables to profile. Supported only in `snowflake-beta` and `BigQuery`",
description="Profile tables only if their size is less then specified GBs. If set to `null`, no limit on the size of tables to profile. Supported only in `snowflake` and `BigQuery`",
)

profile_table_row_limit: Optional[int] = Field(
default=50000,
description="Profile tables only if their row count is less then specified count. If set to `null`, no limit on the row count of tables to profile. Supported only in `snowflake-beta` and `BigQuery`",
description="Profile tables only if their row count is less then specified count. If set to `null`, no limit on the row count of tables to profile. Supported only in `snowflake` and `BigQuery`",
)

# The default of (5 * cpu_count) is adopted from the default max_workers
Expand Down
2 changes: 1 addition & 1 deletion metadata-ingestion/src/datahub/ingestion/source/sql/trino.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ def get_identifier(self: BasicSQLAlchemyConfig, schema: str, table: str) -> str:
)


@platform_name("Trino")
@platform_name("Trino", doc_order=1)
@config_class(TrinoConfig)
@support_status(SupportStatus.CERTIFIED)
@capability(SourceCapability.DOMAINS, "Supported via the `domain` config field")
Expand Down