Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): do not confirm on force for deletion #7106

Merged
merged 5 commits into from
Jan 24, 2023
Merged

fix(ci): do not confirm on force for deletion #7106

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
61c3316
fix(ci): do not confirm on force for deletion
anshbansal Jan 23, 2023
8d1529d
fix lint and add check
anshbansal Jan 23, 2023
53d91d1
do not check for references
anshbansal Jan 23, 2023
b460d1d
delete ref without check on force
anshbansal Jan 23, 2023
3787f94
Merge branch 'master' into aseem-do-not-confirm-on-force
jjoyce0510 Jan 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions metadata-ingestion/src/datahub/cli/delete_cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ def delete(
)
remove_references: bool = False

if references_count > 0:
if (not force) and references_count > 0:
print(
f"This urn was referenced in {references_count} other aspects across your metadata graph:"
)
Expand All @@ -199,7 +199,7 @@ def delete(
)
remove_references = click.confirm("Do you want to delete these references?")

if remove_references:
if force or remove_references:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does force also remove references? I think that all deletes should remove references but not sure if thats communicated in docs

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The -f option in CLI is used to bypass checks for CI. If someone was trying to delete many URNs then this will cause them to need to do yes for each one of them.

I was trying to do this for 90 URNs
datahub delete --urn URN -f

For almost more than half of them of them I had to press y to confirm. Usually all CLIs tools bypass all confirmations when -f is used. I am making the behaviour consistent with that.

delete_references(urn, dry_run=False, cached_session_host=(session, host))

deletion_result: DeletionResult = delete_one_urn_cmd(
Expand Down