fix(ci): do not confirm on force for deletion #7106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
jjoyce0510
reviewed
Jan 24, 2023
| @@ -199,7 +199,7 @@ def delete( | |||
| ) | |||
| remove_references = click.confirm("Do you want to delete these references?") | |||
|
|
|||
| if remove_references: | |||
| if force or remove_references: | |||
There was a problem hiding this comment.
Why does force also remove references? I think that all deletes should remove references but not sure if thats communicated in docs
There was a problem hiding this comment.
The -f option in CLI is used to bypass checks for CI. If someone was trying to delete many URNs then this will cause them to need to do yes for each one of them.
I was trying to do this for 90 URNs
datahub delete --urn URN -f
For almost more than half of them of them I had to press y to confirm. Usually all CLIs tools bypass all confirmations when -f is used. I am making the behaviour consistent with that.
jjoyce0510
approved these changes
Jan 24, 2023
|
Work on fixing the failing cypress is being done in #7116 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist