fix(analytics): add missing usage events causing warning in logs #7109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
devops
|
Expected to fail with |
|
Code check did fail https://github.com/datahub-project/datahub/actions/runs/3989112410/jobs/6841138499 with Added it now. So should pass now. |
|
Code check passed now https://github.com/datahub-project/datahub/actions/runs/3989151394/jobs/6841229205 |
anshbansal
changed the title
jjoyce0510
reviewed
Jan 24, 2023
|
|
||
| ts_events_not_in_java = ts_events.difference(java_events) | ||
| if len(ts_events_not_in_java) > 0: | ||
| print(f"Missing {ts_events_not_in_java} from DataHubUsageEventType.java. Please add") |
There was a problem hiding this comment.
Thanks for adding this. We will need to watch these usage indexes as they continue to grow with all of these new events!
Overall, I like the idea of keeping these in sync.
jjoyce0510
approved these changes
Jan 24, 2023
|
Tested on local and don't see the warning showing up anymore in gms logs. |
|
Work on fixing the failing cypress is being done in #7116 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not having this was causing logs like this in gms which caused confusion.
Checklist