Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tests): Fixing add_users smoke test #7116

Merged
merged 10 commits into from
Jan 24, 2023
Merged

fix(tests): Fixing add_users smoke test #7116

merged 10 commits into from
Jan 24, 2023

Conversation

jjoyce0510
Copy link
Collaborator

Summary

Smoke test for add_users was recently broken. This change ensures that the log out flow goes through the normal browser flow to fix this issue.

Status

Ready for review

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added product PR or Issue related to the DataHub UI/UX smoke_test Contains changes related to smoke tests labels Jan 24, 2023
@anshbansal anshbansal mentioned this pull request Jan 24, 2023
Merged
5 tasks
@anshbansal anshbansal mentioned this pull request Jan 24, 2023
Merged
5 tasks
@jjoyce0510 jjoyce0510 merged commit 50bc591 into datahub-project:master Jan 24, 2023
ericyomi pushed a commit to ericyomi/datahub that referenced this pull request Feb 8, 2023
@jjoyce0510
fix(tests): Fixing add_users smoke test (datahub-project#7116)
9b19168
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aditya-radhakrishnan aditya-radhakrishnan aditya-radhakrishnan approved these changes

Assignees
No one assigned
Labels
product PR or Issue related to the DataHub UI/UX smoke_test Contains changes related to smoke tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jjoyce0510 @aditya-radhakrishnan