Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): Fixing add_users smoke test #7116

Merged
merged 10 commits into from
Jan 24, 2023
Merged

fix(tests): Fixing add_users smoke test #7116

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
3621189
Fixing failing add_users.js test
jjoyce0510 Jan 24, 2023
0cf7ef4
Fix failing tests
jjoyce0510 Jan 24, 2023
42de8e7
Merge remote-tracking branch 'acryl/jj--fix-smoke-test' into jj--fix-…
jjoyce0510 Jan 24, 2023
4a5fbbb
remove unnecessary changes
jjoyce0510 Jan 24, 2023
3160b08
Merge remote-tracking branch 'acryl/jj--fix-smoke-test' into jj--fix-…
jjoyce0510 Jan 24, 2023
f6f65a4
Revert bad smoke test change
jjoyce0510 Jan 24, 2023
faba043
Merge remote-tracking branch 'acryl/jj--fix-smoke-test' into jj--fix-…
jjoyce0510 Jan 24, 2023
736f301
Attempting another go
jjoyce0510 Jan 24, 2023
4982f49
Another try
jjoyce0510 Jan 24, 2023
edfd02a
Merge remote-tracking branch 'acryl/jj--fix-smoke-test' into jj--fix-…
jjoyce0510 Jan 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions datahub-web-react/src/app/shared/ManageAccount.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ export const ManageAccount = ({ urn: _urn, pictureLink: _pictureLink, name }: Pr
<a href="/openapi/swagger-ui/index.html">OpenAPI</a>
</MenuItem>
<Menu.Divider />
<MenuItem danger key="logout" tabIndex={0}>
<MenuItem danger key="logout" tabIndex={0} data-testid="log-out-menu-item">
<a href="/logOut" onClick={handleLogout}>
Sign Out
</a>
Expand All @@ -112,7 +112,7 @@ export const ManageAccount = ({ urn: _urn, pictureLink: _pictureLink, name }: Pr

return (
<Dropdown overlay={menu} trigger={['click']}>
<DropdownWrapper>
<DropdownWrapper data-testid="manage-account-menu">
<CustomAvatar photoUrl={_pictureLink} style={{ marginRight: 4 }} name={name} />
<DownArrow />
</DropdownWrapper>
Expand Down
1 change: 1 addition & 0 deletions smoke-test/tests/cypress/cypress/integration/mutations/add_users.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ describe("add_user", () => {
cy.waitTextVisible(/signup\?invite_token=\w+/).then(($elem) => {
const inviteLink = $elem.text();
cy.log(inviteLink);
cy.visit("/settings/identities/users");
cy.logout();
cy.visit(inviteLink);
let name = tryToSignUp();
Expand Down