Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): do not fail fast for matrix runs #7132

Merged
merged 2 commits into from
Jan 25, 2023
Merged

fix(ci): do not fail fast for matrix runs #7132

merged 2 commits into from
Jan 25, 2023

Conversation

anshbansal
Copy link
Collaborator

@anshbansal anshbansal commented Jan 25, 2023 •
edited
Loading

We want other runs to still go on in case of failure in one. Not having these fail fast causes situations where others also get cancelled which we don't want.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@anshbansal anshbansal requested review from pedro93 and szalai1 January 25, 2023 09:11
@github-actions github-actions bot added the devops PR or Issue related to DataHub backend & deployment label Jan 25, 2023
@jjoyce0510 jjoyce0510 merged commit e880f14 into master Jan 25, 2023
@jjoyce0510 jjoyce0510 deleted the aseem-do-not-fail-fast branch January 25, 2023 17:31
@anshbansal anshbansal mentioned this pull request Jan 29, 2023
Closed
5 tasks
ericyomi pushed a commit to ericyomi/datahub that referenced this pull request Feb 8, 2023
@anshbansal
fix(ci): do not fail fast for matrix runs (datahub-project#7132)
1fcce92
oleg-ruban pushed a commit to RChygir/datahub that referenced this pull request Feb 28, 2023
@anshbansal
fix(ci): do not fail fast for matrix runs (datahub-project#7132)
a5168d1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjoyce0510 jjoyce0510 jjoyce0510 approved these changes

@pedro93 pedro93 pedro93 approved these changes

@szalai1 szalai1 Awaiting requested review from szalai1

Assignees
No one assigned
Labels
devops PR or Issue related to DataHub backend & deployment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anshbansal @pedro93 @jjoyce0510