Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crossport core-located metadata bug-fixes #71

Merged
merged 3 commits into from
Oct 21, 2022

Conversation

christian-monch
Copy link
Contributor

This PR adds bug-fixes that have been applied to the metadata core since the metadata code was added to datalad-deprecated

@codecov-commenter
Copy link

Codecov Report

Base: 89.50% // Head: 80.47% // Decreases project coverage by -9.03% ⚠️

Coverage data is based on head (a9e5f64) compared to base (fb171bd).
Patch coverage: 71.20% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #71      +/-   ##
==========================================
- Coverage   89.50%   80.47%   -9.04%     
==========================================
  Files          22       58      +36     
  Lines        2831     5347    +2516     
==========================================
+ Hits         2534     4303    +1769     
- Misses        297     1044     +747     
Impacted Files Coverage Δ
datalad_deprecated/__init__.py 100.00% <ø> (ø)
datalad_deprecated/metadata/aggregate.py 15.08% <15.08%> (ø)
datalad_deprecated/metadata/annotate_paths.py 32.00% <32.00%> (ø)
datalad_deprecated/metadata/search.py 47.40% <47.40%> (ø)
datalad_deprecated/metadata/utils.py 48.00% <48.00%> (ø)
datalad_deprecated/metadata/metadata.py 62.36% <62.36%> (ø)
datalad_deprecated/metadata/extractors/base.py 83.33% <83.33%> (ø)
..._deprecated/metadata/extractors/tests/test_base.py 87.80% <87.80%> (ø)
datalad_deprecated/metadata/indexers/base.py 88.88% <88.88%> (ø)
datalad_deprecated/metadata/extractors/datacite.py 89.58% <89.58%> (ø)
... and 40 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yarikoptic yarikoptic added release Create a release when this pr is merged patch Increment the patch version when merged labels Oct 21, 2022
@yarikoptic yarikoptic merged commit 6f5a029 into datalad:master Oct 21, 2022
@github-actions
Copy link

🚀 PR was released in 0.2.5 🚀

@github-actions github-actions bot added the released This issue/pull request has been released. label Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged release Create a release when this pr is merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants