Adapt to the move of metadata-code from datalad to datalad-deprecated
#111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christian-monch
force-pushed
the
mnt-adapt-to-metadata-move-from-core
branch
from
b9f4b92 to
d2c678e
Compare
This commit fixes the code to use the metadata code that has been moved from datalad to datalad-deprecated. This refers to all code in `datalad.metadata`.
christian-monch
force-pushed
the
mnt-adapt-to-metadata-move-from-core
branch
from
d2c678e to
e510d24
Compare
|
Remaining errors should be fixed after |
|
Thank you ! I have merged and released deprecated 0.2.5 , you might like to add versioning to depends |
Codecov ReportBase: 89.47% // Head: 89.61% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #111 +/- ##
==========================================
+ Coverage 89.47% 89.61% +0.14%
==========================================
Files 24 24
Lines 1159 1175 +16
==========================================
+ Hits 1037 1053 +16
Misses 122 122
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
bpoldrack
reviewed
Oct 24, 2022
|
Thx, @christian-monch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adapts the parts of
datalad_neuroimagingthat used the old metadata code, i.e. the code contained indatalad.metadata, to the new location of this code, i.e.datalad_deprecated.metadata.