Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP INI file can be fully truncated or contents duplicated when using cargo-php #134

Closed
roborourke opened this issue May 4, 2022 · 0 comments
Closed

PHP INI file can be fully truncated or contents duplicated when using cargo-php #134

roborourke opened this issue May 4, 2022 · 0 comments

Comments

@roborourke
Copy link
Contributor

I noticed then when using cargo-php remove the INI file contents are completely truncated.

Additionally when using cargo-php install the file contents are duplicated leading to the extension= lines doubling up and PHP throwing an error due to trying to load libv8js.soextension or similar.
roborourke added a commit to roborourke/ext-php-rs that referenced this issue May 4, 2022
@roborourke
Fix INI file truncation and duplication
6d29de0 
Addresses davidcole1340#134

Also prevents adding the extension include line twice.
@roborourke roborourke mentioned this issue May 4, 2022
Merged
roborourke added a commit to roborourke/ext-php-rs that referenced this issue Jun 28, 2022
@roborourke
Fix INI file truncation and duplication
6484664 
Addresses davidcole1340#134

Also prevents adding the extension include line twice.
davidcole1340 pushed a commit that referenced this issue Sep 30, 2022
@roborourke
Fix INI file truncation and duplication (#136)
7dac401 
Addresses #134

Also prevents adding the extension include line twice.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@roborourke