Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ini file duplication and truncation when using cargo-php command #136

Merged

Conversation

roborourke
Copy link
Contributor

Addresses #134

Also prevents the extension line from being added twice on subsequent calls.

@roborourke roborourke changed the title Fix ini file handling Fix ini file duplication and truncation when using cargo-php command May 4, 2022
@roborourke
Copy link
Contributor Author

Whoops, some unintended changes from #135 made it into this one

Addresses davidcole1340#134

Also prevents adding the extension include line twice.
@roborourke roborourke force-pushed the fix-ini-file-handling branch from bffd7c3 to 6484664 Compare June 28, 2022 14:25
@roborourke
Copy link
Contributor Author

Cleaned the history on this PR so it's self contained.

@davidcole1340 davidcole1340 merged commit 7dac401 into davidcole1340:master Sep 30, 2022
@davidcole1340
Copy link
Owner

Thank you!

@roborourke roborourke deleted the fix-ini-file-handling branch October 1, 2022 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants