-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
passing the path into the log file and browser console #57
Comments
@frankthepunk, funny you should mention this. We just merged in #56 and published [email protected]. this will now log caller file name and line number. |
Hi David,
that sounds good! ☺
Thanks for your work!
Does the path comes automatically when I update the ngxlogger version or is there a curtain way for implementation?
Frank
Von: David [mailto:[email protected]]
Gesendet: Donnerstag, 12. April 2018 15:53
An: dbfannin/ngx-logger
Cc: Mehlhop, Frank (extern); Mention
Betreff: Re: [dbfannin/ngx-logger] passing the path into the log file and browser console (#57)
@frankthepunk<https://github.com/frankthepunk>, funny you should mention this. We just merged in #56<#56> and published [email protected]<mailto:[email protected]>. this will now log caller file name and line number.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#57 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AjpKx6jdsO_U9ntv4fvVHBSP6OM64WWpks5tn1xEgaJpZM4TRN34>.
…--
KPMG IT Service GmbH
Sitz/Registergericht: Berlin/Amtsgericht Charlottenburg, HRB 87521 B
Geschäftsführer: Hans-Christian Schwieger, Helmar Symmank
Die Information in dieser E-Mail ist vertraulich und kann dem Berufsgeheimnis unterliegen. Sie ist ausschließlich für den Adressaten bestimmt. Jeglicher Zugriff auf diese E-Mail durch andere Personen als den Adressaten ist untersagt. Sollten Sie nicht der für diese E-Mail bestimmte Adressat sein, ist Ihnen jede Veröffentlichung, Vervielfältigung oder Weitergabe wie auch das Ergreifen oder Unterlassen von Maßnahmen im Vertrauen auf erlangte Information untersagt. In dieser E-Mail enthaltene Meinungen oder Empfehlungen unterliegen den Bedingungen des jeweiligen Mandatsverhältnisses mit dem Adressaten.
The information in this e-mail is confidential and may be legally privileged. It is intended solely for the addressee. Access to this e-mail by anyone else is unauthorized. If you are not the intended recipient, any disclosure, copying, distribution or any action taken or omitted to be taken in reliance on it, is prohibited and may be unlawful. Any opinions or advice contained in this e-mail are subject to the terms and conditions expressed in the governing KPMG client engagement letter.
|
it comes automatically. It will be in the message prefix. Let me know if you have problems! |
@danibs, the file/path name is in the metastring prefix of the logged message. in your case |
What I mean is that console.log tell me what is the source of filename:lineNumber and this information is more usefull during development. The two lines:
are in the same file, the first above the second. |
@danibs, it's still not clear to me what the problem is. Is it that the right hand side file name and line number is different? if so, that is known, and there isn't a solution for that yet. Is it that the file name and number in the metastring is incorrect? If so, we can look into why this isn't working as expected. |
@dbfannin, what you said <<if so, that is known, and there isn't a solution for that yet>> is the answer of my doubts. I thought that with new version you found a solution for that! I didn't check if file name and number in the metastring is incorrect, sorry. |
@danibs, no worries! Still looking for a way to reflect the file name line number on the RHS. |
@dbfannin, I thought to one thing: maybe that Node, during compile, translate |
@dbfannin, I check inside transpilled file and I found this: https://stackoverflow.com/a/49283274 Thanks! |
closing as a duplicate of #69 |
@dbfannin |
I think for now it's not possible, it's coming with V5 :) |
Hi,
my name is Frank,
I got a concern.
Is it possible to log automatically the file name or even better the path of the calling file?
I use your very comfortable NGXLogger inside an Angular-application and the logs are written inside the C# backend.
Of course I could write inside my node.js
this.logger.debug('mySpecial.component.ts | the message');
, but it would be great, when that is integrated in NGXLogger.
Sincerely,
Frank
The text was updated successfully, but these errors were encountered: